[U-Boot] [PATCH] cmd_mmc: use common usage function

Rather than using a custom "Usage:", use the common cmd_usage() function.
Signed-off-by: Mike Frysinger vapier@gentoo.org --- common/cmd_mmc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index 698157f..329ef09 100644 --- a/common/cmd_mmc.c +++ b/common/cmd_mmc.c @@ -161,7 +161,7 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) case 0: case 1: case 4: - printf("Usage:\n%s\n", cmdtp->usage); + cmd_usage(cmdtp); return 1;
case 2: @@ -218,7 +218,7 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) n, (n == cnt) ? "OK" : "ERROR"); return (n == cnt) ? 0 : 1; } else { - printf("Usage:\n%s\n", cmdtp->usage); + cmd_usage(cmdtp); rc = 1; }

Rather than using a custom "Usage:", use the common cmd_usage() function, and tail into it now that it returns 1 for us.
Signed-off-by: Mike Frysinger vapier@gentoo.org --- v2 - tail into cmd_usage() as pointed out by Detlev Zundel
common/cmd_mmc.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index e5f5e94..5ee73ab 100644 --- a/common/cmd_mmc.c +++ b/common/cmd_mmc.c @@ -156,8 +156,7 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) case 0: case 1: case 4: - printf("Usage:\n%s\n", cmdtp->usage); - return 1; + return cmd_usage(cmdtp);
case 2: if (!strcmp(argv[1], "list")) { @@ -212,10 +211,8 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) printf("%d blocks written: %s\n", n, (n == cnt) ? "OK" : "ERROR"); return (n == cnt) ? 0 : 1; - } else { - printf("Usage:\n%s\n", cmdtp->usage); - rc = 1; - } + } else + rc = cmd_usage(cmdtp);
return rc; }

Dear Mike Frysinger,
In message 1280425243-25290-1-git-send-email-vapier@gentoo.org you wrote:
Rather than using a custom "Usage:", use the common cmd_usage() function, and tail into it now that it returns 1 for us.
Signed-off-by: Mike Frysinger vapier@gentoo.org
v2
- tail into cmd_usage() as pointed out by Detlev Zundel
common/cmd_mmc.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Mike Frysinger
-
Wolfgang Denk