[PATCH] tools: env: Fix missing closedir in ubi_get_volnum_by_name

The function calls opendir() but missing the corresponding closedir() before exit the function. Add missing closedir() to fix it.
Signed-off-by: Miaoqian Lin linmq006@gmail.com --- tools/env/fw_env.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 2a61a5d6f049..eb138accdcbe 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -192,10 +192,13 @@ static int ubi_get_volnum_by_name(int devnum, const char *volname) &tmp_devnum, &volnum); if (ret == 2 && devnum == tmp_devnum) { if (ubi_check_volume_sysfs_name(dirent->d_name, - volname) == 0) + volname) == 0) { + closedir(sysfs_ubi); return volnum; + } } } + closedir(sysfs_ubi);
return -1; }

On Mon, Sep 19, 2022 at 08:28:09AM +0400, Miaoqian Lin wrote:
The function calls opendir() but missing the corresponding closedir() before exit the function. Add missing closedir() to fix it.
Signed-off-by: Miaoqian Lin linmq006@gmail.com
Applied to u-boot/master, thanks!
participants (2)
-
Miaoqian Lin
-
Tom Rini