[U-Boot] [PATCH] Kconfig: Add EXPERT option
For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.
Signed-off-by: Tom Rini trini@ti.com --- Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/Kconfig b/Kconfig index e0c8992..73785b00 100644 --- a/Kconfig +++ b/Kconfig @@ -58,6 +58,14 @@ config CC_OPTIMIZE_FOR_SIZE
endmenu # General setup
+menuconfig EXPERT + bool "Configure standard U-Boot features (expert users)" + help + This option allows certain base U-Boot options and settings + to be disabled or tweaked. This is for specialized + environments which can tolerate a "non-standard" U-Boot. + Only use this if you really know what you are doing. + menu "Boot images"
config SPL_BUILD
Hi Tom,
On Tue, 14 Oct 2014 08:39:20 -0400, Tom Rini trini@ti.com wrote:
For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.
Signed-off-by: Tom Rini trini@ti.com
Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/Kconfig b/Kconfig index e0c8992..73785b00 100644 --- a/Kconfig +++ b/Kconfig @@ -58,6 +58,14 @@ config CC_OPTIMIZE_FOR_SIZE
endmenu # General setup
+menuconfig EXPERT
bool "Configure standard U-Boot features (expert users)"helpThis option allows certain base U-Boot options and settingsto be disabled or tweaked. This is for specializedenvironments which can tolerate a "non-standard" U-Boot.Only use this if you really know what you are doing.menu "Boot images"
config SPL_BUILD
Half-OT: we have a policy of not adding dead code in U-Boot. Here, this Kconfig change introduces CONFIG_EXPERT, but nowhere in the code is it used. Should we consider this dead code as well (and thus, expect/accept it only in a patch series where the EXPERT config is used somewhere else in the code) or not?
Amicalement,
On Wed, Oct 15, 2014 at 12:19:58AM +0200, Albert ARIBAUD wrote:
Hi Tom,
On Tue, 14 Oct 2014 08:39:20 -0400, Tom Rini trini@ti.com wrote:
For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.
Signed-off-by: Tom Rini trini@ti.com
Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/Kconfig b/Kconfig index e0c8992..73785b00 100644 --- a/Kconfig +++ b/Kconfig @@ -58,6 +58,14 @@ config CC_OPTIMIZE_FOR_SIZE
endmenu # General setup
+menuconfig EXPERT
bool "Configure standard U-Boot features (expert users)"helpThis option allows certain base U-Boot options and settingsto be disabled or tweaked. This is for specializedenvironments which can tolerate a "non-standard" U-Boot.Only use this if you really know what you are doing.menu "Boot images"
config SPL_BUILD
Half-OT: we have a policy of not adding dead code in U-Boot. Here, this Kconfig change introduces CONFIG_EXPERT, but nowhere in the code is it used. Should we consider this dead code as well (and thus, expect/accept it only in a patch series where the EXPERT config is used somewhere else in the code) or not?
I told Michal Simek to wait until I posted this to follow up and post a patch adding something else which will make use of this. And depending on time, I may get there first and make use of this for other conersions as well.
2014-10-15 15:08 GMT+09:00 Tom Rini trini@ti.com:
On Wed, Oct 15, 2014 at 12:19:58AM +0200, Albert ARIBAUD wrote:
Hi Tom,
On Tue, 14 Oct 2014 08:39:20 -0400, Tom Rini trini@ti.com wrote:
For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.
Signed-off-by: Tom Rini trini@ti.com
Acked-by: Masahiro Yamada yamada.m@jp.panasonic.com
participants (3)
-
Albert ARIBAUD -
Masahiro YAMADA -
Tom Rini