[U-Boot] [PATCH V2] imx: mx7: Add support for USB and normal boot modes
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
1. "bmode usb" can be used to force the ROM boot loader's serial 2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com --- V2 adds "normal" mode as suggested by Troy Kisky arch/arm/mach-imx/mx7/soc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c index 87bf105..15be42a 100644 --- a/arch/arm/mach-imx/mx7/soc.c +++ b/arch/arm/mach-imx/mx7/soc.c @@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog) * to SBMR1, which will determine the boot device. */ const struct boot_mode soc_boot_modes[] = { + {"normal", MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)}, + {"usb", MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)}, + {"ecspi1:0", MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)}, {"ecspi1:1", MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)}, {"ecspi1:2", MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
Sorry for the spam.
I resent this by mistake.
On 08/30/2017 03:13 PM, Eric Nelson wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
V2 adds "normal" mode as suggested by Troy Kisky arch/arm/mach-imx/mx7/soc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c index 87bf105..15be42a 100644 --- a/arch/arm/mach-imx/mx7/soc.c +++ b/arch/arm/mach-imx/mx7/soc.c @@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
- to SBMR1, which will determine the boot device.
*/ const struct boot_mode soc_boot_modes[] = {
- {"normal", MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
- {"usb", MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
- {"ecspi1:0", MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)}, {"ecspi1:1", MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)}, {"ecspi1:2", MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
Hi Eric,
On Wed, Aug 30, 2017 at 7:13 PM, Eric Nelson eric@nelint.com wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.
I also did:
diff --git a/configs/mx7dsabresd_defconfig b/configs/mx7dsabresd_defconfig index 8f2e33a..c70fde8 100644 --- a/configs/mx7dsabresd_defconfig +++ b/configs/mx7dsabresd_defconfig @@ -5,7 +5,6 @@ CONFIG_VIDEO=y # CONFIG_ARMV7_VIRT is not set CONFIG_IMX_RDC=y CONFIG_IMX_BOOTAUX=y -# CONFIG_CMD_BMODE is not set CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb" CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg" CONFIG_BOOTDELAY=3
so that bmode command can be added.
However I am getting:
=> bmode usb bmode - <NULL>
Usage: bmode => bmode normal bmode - <NULL>
Usage: bmode =>
Any ideas?
Thanks
On Thu, Aug 31, 2017 at 10:35 AM, Fabio Estevam festevam@gmail.com wrote:
Hi Eric,
On Wed, Aug 30, 2017 at 7:13 PM, Eric Nelson eric@nelint.com wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.
I also did:
diff --git a/configs/mx7dsabresd_defconfig b/configs/mx7dsabresd_defconfig index 8f2e33a..c70fde8 100644 --- a/configs/mx7dsabresd_defconfig +++ b/configs/mx7dsabresd_defconfig @@ -5,7 +5,6 @@ CONFIG_VIDEO=y # CONFIG_ARMV7_VIRT is not set CONFIG_IMX_RDC=y CONFIG_IMX_BOOTAUX=y -# CONFIG_CMD_BMODE is not set CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb" CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg" CONFIG_BOOTDELAY=3
so that bmode command can be added.
However I am getting:
=> bmode usb bmode - <NULL>
I missed to add 'add_board_boot_modes(board_boot_modes);'
Now I get:
=> bmode usb resetting ...
U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)
CPU: Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) CPU: Commercial temperature grade (0C to 95C) at 41C Reset cause: POR Model: Freescale i.MX7 SabreSD Board Board: i.MX7D SABRESD in non-secure mode DRAM: 1 GiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: MMC Device 0 not found *** Warning - No MMC card found, using default environment
Video: 480x272x24 In: serial Out: serial Err: serial Net: FEC0 Hit any key to stop autoboot: 0 =>
So the board is resetting instead of going into serial download mode.
Any ideas?
Thanks
Hi Fabio,
On 08/31/2017 06:56 AM, Fabio Estevam wrote:
On Thu, Aug 31, 2017 at 10:35 AM, Fabio Estevam festevam@gmail.com wrote:
Hi Eric,
On Wed, Aug 30, 2017 at 7:13 PM, Eric Nelson eric@nelint.com wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.
I also did:
diff --git a/configs/mx7dsabresd_defconfig b/configs/mx7dsabresd_defconfig index 8f2e33a..c70fde8 100644 --- a/configs/mx7dsabresd_defconfig +++ b/configs/mx7dsabresd_defconfig @@ -5,7 +5,6 @@ CONFIG_VIDEO=y # CONFIG_ARMV7_VIRT is not set CONFIG_IMX_RDC=y CONFIG_IMX_BOOTAUX=y -# CONFIG_CMD_BMODE is not set CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb" CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg" CONFIG_BOOTDELAY=3
so that bmode command can be added.
However I am getting:
=> bmode usb bmode - <NULL>
I missed to add 'add_board_boot_modes(board_boot_modes);'
Now I get:
=> bmode usb resetting ...
U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)
CPU: Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) CPU: Commercial temperature grade (0C to 95C) at 41C Reset cause: POR Model: Freescale i.MX7 SabreSD Board Board: i.MX7D SABRESD in non-secure mode DRAM: 1 GiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: MMC Device 0 not found *** Warning - No MMC card found, using default environment
Video: 480x272x24 In: serial Out: serial Err: serial Net: FEC0 Hit any key to stop autoboot: 0 =>
So the board is resetting instead of going into serial download mode.
Any ideas?
I'm not sure. Since I'm currently working with a board with no fuses blown, I'm getting USB mode either way ;)...
I have an MX7 SABRE SD and I'll try it out there.
Regards,
Eric
On 8/31/2017 6:56 AM, Fabio Estevam wrote:
On Thu, Aug 31, 2017 at 10:35 AM, Fabio Estevam festevam@gmail.com wrote:
Hi Eric,
On Wed, Aug 30, 2017 at 7:13 PM, Eric Nelson eric@nelint.com wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.
I also did:
diff --git a/configs/mx7dsabresd_defconfig b/configs/mx7dsabresd_defconfig index 8f2e33a..c70fde8 100644 --- a/configs/mx7dsabresd_defconfig +++ b/configs/mx7dsabresd_defconfig @@ -5,7 +5,6 @@ CONFIG_VIDEO=y # CONFIG_ARMV7_VIRT is not set CONFIG_IMX_RDC=y CONFIG_IMX_BOOTAUX=y -# CONFIG_CMD_BMODE is not set CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb" CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg" CONFIG_BOOTDELAY=3
so that bmode command can be added.
However I am getting:
=> bmode usb bmode - <NULL>
I missed to add 'add_board_boot_modes(board_boot_modes);'
Now I get:
=> bmode usb resetting ...
U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)
CPU: Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) CPU: Commercial temperature grade (0C to 95C) at 41C Reset cause: POR Model: Freescale i.MX7 SabreSD Board Board: i.MX7D SABRESD in non-secure mode DRAM: 1 GiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: MMC Device 0 not found *** Warning - No MMC card found, using default environment
Video: 480x272x24 In: serial Out: serial Err: serial Net: FEC0 Hit any key to stop autoboot: 0 =>
So the board is resetting instead of going into serial download mode.
Any ideas?
I got this response from Peng when I asked him back in March of last year.
For now, bmode does not work. Since bmode use warm reset, but we now use wdog to directly reset pmic. So bmode will not work.
Please check your code to see whether your board connect WDOG_B to pmic reset pin and have wdog
pinmux settings.
Thanks, Peng.
Maybe if you change the WDOG pinmux it might work ?
Troy
On 8/31/2017 2:28 PM, Troy Kisky wrote:
Maybe if you change the WDOG pinmux it might work ?
Worked for me
=> mm.l 302c0000 302c0000: 00000003 ? 0 302c0004: 00000001 ? q => bmod usb resetting ...
On 08/31/2017 03:53 PM, Troy Kisky wrote:
On 8/31/2017 2:28 PM, Troy Kisky wrote:
Maybe if you change the WDOG pinmux it might work ?
Worked for me
=> mm.l 302c0000 302c0000: 00000003 ? 0 302c0004: 00000001 ? q => bmod usb resetting ...
Hmm...
On SABRE-SD or Nitrogen7?
On 8/31/2017 4:04 PM, Eric Nelson wrote:
On 08/31/2017 03:53 PM, Troy Kisky wrote:
On 8/31/2017 2:28 PM, Troy Kisky wrote:
Maybe if you change the WDOG pinmux it might work ?
Worked for me
=> mm.l 302c0000 302c0000: 00000003 ? 0 302c0004: 00000001 ? q => bmod usb resetting ...
Hmm...
On SABRE-SD or Nitrogen7?
Nitrogen7,
It does show up in lsusb afterwards Bus 003 Device 100: ID 15a2:0076 Freescale Semiconductor, Inc.
But imx_usb gets errors afterwards
== work item filename /tftpboot/u-boot.nitrogen7 load_size 0 bytes load_addr 0x00000000 dcd 1 clear_dcd 0 plug 1 jump_mode 2 jump_addr 0x00000000 == end work item loading DCD table @0x910000
<<<-564, 1024 bytes>>> report 3 in err=-7, last_trans=0 c4 34 03 32 report 4 in err=-7, last_trans=0 c4 34 03 32 failed (status 0x320334c4) ________________
So, close but no cigar.
On 8/31/2017 4:13 PM, Troy Kisky wrote:
On 8/31/2017 4:04 PM, Eric Nelson wrote:
On 08/31/2017 03:53 PM, Troy Kisky wrote:
On 8/31/2017 2:28 PM, Troy Kisky wrote:
Maybe if you change the WDOG pinmux it might work ?
Worked for me
=> mm.l 302c0000 302c0000: 00000003 ? 0 302c0004: 00000001 ? q => bmod usb resetting ...
Hmm...
On SABRE-SD or Nitrogen7?
Nitrogen7,
It does show up in lsusb afterwards Bus 003 Device 100: ID 15a2:0076 Freescale Semiconductor, Inc.
But imx_usb gets errors afterwards
== work item filename /tftpboot/u-boot.nitrogen7 load_size 0 bytes load_addr 0x00000000 dcd 1 clear_dcd 0 plug 1 jump_mode 2 jump_addr 0x00000000 == end work item loading DCD table @0x910000
<<<-564, 1024 bytes>>> report 3 in err=-7, last_trans=0 c4 34 03 32 report 4 in err=-7, last_trans=0 c4 34 03 32 failed (status 0x320334c4) ________________
So, close but no cigar.
FYI
=> mw.l 302c0000 0 => reset resetting ... ___________________
Also just hangs. So, it is not "bmode" specify.
Troy,
On Thu, Aug 31, 2017 at 7:53 PM, Troy Kisky troy.kisky@boundarydevices.com wrote:
On 8/31/2017 2:28 PM, Troy Kisky wrote:
Maybe if you change the WDOG pinmux it might work ?
Worked for me
=> mm.l 302c0000 302c0000: 00000003 ? 0 302c0004: 00000001 ? q => bmod usb resetting ...
Ok, but did you manage to successfully transfer u-boot via imx_usb_loader?
It did not work for me.
Thanks
On 08/31/2017 04:11 PM, Fabio Estevam wrote:
Troy,
On Thu, Aug 31, 2017 at 7:53 PM, Troy Kisky troy.kisky@boundarydevices.com wrote:
On 8/31/2017 2:28 PM, Troy Kisky wrote:
Maybe if you change the WDOG pinmux it might work ?
Worked for me
=> mm.l 302c0000 302c0000: 00000003 ? 0 302c0004: 00000001 ? q => bmod usb resetting ...
Ok, but did you manage to successfully transfer u-boot via imx_usb_loader?
It did not work for me.
Ditto here. The OTG port didn't re-enumerate.
Thanks Troy (and Peng),
On 08/31/2017 02:28 PM, Troy Kisky wrote:
On 8/31/2017 6:56 AM, Fabio Estevam wrote:
On Thu, Aug 31, 2017 at 10:35 AM, Fabio Estevam festevam@gmail.com wrote:
On Wed, Aug 30, 2017 at 7:13 PM, Eric Nelson eric@nelint.com wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.
I also did:
diff --git a/configs/mx7dsabresd_defconfig b/configs/mx7dsabresd_defconfig index 8f2e33a..c70fde8 100644 --- a/configs/mx7dsabresd_defconfig +++ b/configs/mx7dsabresd_defconfig @@ -5,7 +5,6 @@ CONFIG_VIDEO=y # CONFIG_ARMV7_VIRT is not set CONFIG_IMX_RDC=y CONFIG_IMX_BOOTAUX=y -# CONFIG_CMD_BMODE is not set CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb" CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg" CONFIG_BOOTDELAY=3
so that bmode command can be added.
However I am getting:
=> bmode usb bmode - <NULL>
I missed to add 'add_board_boot_modes(board_boot_modes);'
Now I get:
=> bmode usb resetting ...
U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)
CPU: Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) CPU: Commercial temperature grade (0C to 95C) at 41C
Note the POR here (I would expect it to be WDOG).
Reset cause: POR Model: Freescale i.MX7 SabreSD Board Board: i.MX7D SABRESD in non-secure mode DRAM: 1 GiB
<snip>
I got this response from Peng when I asked him back in March of last year.
For now, bmode does not work. Since bmode use warm reset, but we now use wdog to directly reset pmic. So bmode will not work.
Please check your code to see whether your board connect WDOG_B to pmic reset pin and have wdog
pinmux settings.
Thanks, Peng.
Maybe if you change the WDOG pinmux it might work ?
The mx7dsabresd has GPIO1_IO00 configured for WDOG, and overriding it does get rid of the POR.
Unfortunately, it also doesn't allow "bmode usb" to function.
=> mm 302c0000 302c0000: 00000003 ? 0 302c0004: 00000000 ? x => bmode usb resetting ...
(crickets here)
Based on this:
Rejected-by: Eric Nelson eric@nelint.com
On 31/08/2017 00:13, Eric Nelson wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
V2 adds "normal" mode as suggested by Troy Kisky arch/arm/mach-imx/mx7/soc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c index 87bf105..15be42a 100644 --- a/arch/arm/mach-imx/mx7/soc.c +++ b/arch/arm/mach-imx/mx7/soc.c @@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
- to SBMR1, which will determine the boot device.
*/ const struct boot_mode soc_boot_modes[] = {
- {"normal", MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
- {"usb", MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
- {"ecspi1:0", MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)}, {"ecspi1:1", MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)}, {"ecspi1:2", MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
Sorry, it was for a long time in the queue - discussion in thread is spreading away from the original review (I had errouneosly set it to Changes requested).
Applied to u-boot-imx, -master, thanks !
Best regards, Stefano
Hi Stefano,
On 10/02/2017 06:21 AM, Stefano Babic wrote:
On 31/08/2017 00:13, Eric Nelson wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
V2 adds "normal" mode as suggested by Troy Kisky arch/arm/mach-imx/mx7/soc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c index 87bf105..15be42a 100644 --- a/arch/arm/mach-imx/mx7/soc.c +++ b/arch/arm/mach-imx/mx7/soc.c @@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
- to SBMR1, which will determine the boot device.
*/ const struct boot_mode soc_boot_modes[] = {
- {"normal", MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
- {"usb", MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
- {"ecspi1:0", MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)}, {"ecspi1:1", MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)}, {"ecspi1:2", MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
Sorry, it was for a long time in the queue - discussion in thread is spreading away from the original review (I had errouneosly set it to Changes requested).
Applied to u-boot-imx, -master, thanks !
Sorry, but we rejected this patch (because it doesn't work).
https://patchwork.ozlabs.org/patch/807934/
Regards,
Eric
On 02/10/2017 16:19, Eric Nelson wrote:
Hi Stefano,
On 10/02/2017 06:21 AM, Stefano Babic wrote:
On 31/08/2017 00:13, Eric Nelson wrote:
This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.
- "bmode usb" can be used to force the ROM boot loader's serial
- "bmode normal" can be used to revert to the normal boot mode
as specified by fuses and BOOT_MODE pins
Signed-off-by: Eric Nelson eric@nelint.com
V2 adds "normal" mode as suggested by Troy Kisky arch/arm/mach-imx/mx7/soc.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c index 87bf105..15be42a 100644 --- a/arch/arm/mach-imx/mx7/soc.c +++ b/arch/arm/mach-imx/mx7/soc.c @@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog) * to SBMR1, which will determine the boot device. */ const struct boot_mode soc_boot_modes[] = { + {"normal", MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)}, + {"usb", MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
{"ecspi1:0", MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)}, {"ecspi1:1", MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)}, {"ecspi1:2", MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
Sorry, it was for a long time in the queue - discussion in thread is spreading away from the original review (I had errouneosly set it to Changes requested).
Applied to u-boot-imx, -master, thanks !
Sorry, but we rejected this patch (because it doesn't work).
Thanks, I have not seen it - I drop it.
Best regards, Stefano
participants (4)
-
Eric Nelson -
Fabio Estevam -
Stefano Babic -
Troy Kisky