[U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by: “Suriyan Ramasami" suriyan.r@gmail.com --- drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 15fd9a9..7bf0a34 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -14,6 +14,12 @@
/* SMSC LAN95xx based USB 2.0 Ethernet Devices */
+/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000) + /* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000 #define TX_CMD_A_LAST_SEG_ 0x00001000 @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd) return ret; debug("ID_REV = 0x%08x\n", read_buf);
+ /* Configure GPIO pins as LED outputs */ + write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED | + LED_GPIO_CFG_FDX_LED; + ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf); + if (ret < 0) + return ret; + debug("LED_GPIO_CFG set\n"); + /* Init Tx */ write_buf = 0; ret = smsc95xx_write_reg(dev, FLOW, write_buf);
+Joe (net maintainer) +Marek (USB)
Hi Suriyan,
On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami suriyan.r@gmail.comwrote:
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by: “Suriyan Ramasami" suriyan.r@gmail.com
drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 15fd9a9..7bf0a34 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -14,6 +14,12 @@
/* SMSC LAN95xx based USB 2.0 Ethernet Devices */
+/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000)
/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000 #define TX_CMD_A_LAST_SEG_ 0x00001000 @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd) return ret; debug("ID_REV = 0x%08x\n", read_buf);
/* Configure GPIO pins as LED outputs */write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |LED_GPIO_CFG_FDX_LED;ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);if (ret < 0)return ret;debug("LED_GPIO_CFG set\n");
Seems good.
Acked-by: Simon Glass sjg@chromium.org
/* Init Tx */ write_buf = 0; ret = smsc95xx_write_reg(dev, FLOW, write_buf);-- 1.7.1
Dear Simon Glass,
+Joe (net maintainer) +Marek (USB)
Hi Suriyan,
On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami suriyan.r@gmail.comwrote:
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by: “Suriyan Ramasami" suriyan.r@gmail.com
drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 15fd9a9..7bf0a34 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -14,6 +14,12 @@
/* SMSC LAN95xx based USB 2.0 Ethernet Devices */
+/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000)
/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000 #define TX_CMD_A_LAST_SEG_ 0x00001000
@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)
return ret; debug("ID_REV = 0x%08x\n", read_buf);
/* Configure GPIO pins as LED outputs */write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |LED_GPIO_CFG_FDX_LED;ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);if (ret < 0)return ret;debug("LED_GPIO_CFG set\n");Seems good.
Acked-by: Simon Glass sjg@chromium.org
Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Best regards, Marek Vasut
On Oct 9, 2013, at 6:39 PM, Marek Vasut marex@denx.de wrote:
Dear Simon Glass,
+Joe (net maintainer) +Marek (USB)
Hi Suriyan,
On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami suriyan.r@gmail.comwrote:
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by: “Suriyan Ramasami" suriyan.r@gmail.com
drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 15fd9a9..7bf0a34 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -14,6 +14,12 @@
/* SMSC LAN95xx based USB 2.0 Ethernet Devices */
+/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000)
/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000 #define TX_CMD_A_LAST_SEG_ 0x00001000
@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)
return ret; debug("ID_REV = 0x%08x\n", read_buf);
/* Configure GPIO pins as LED outputs */write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |LED_GPIO_CFG_FDX_LED;ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);if (ret < 0)return ret;debug("LED_GPIO_CFG set\n");Seems good.
Acked-by: Simon Glass sjg@chromium.org
Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Sure... When I need to be.
Best regards, Marek Vasut
Dear Joe Hershberger,
On Oct 9, 2013, at 6:39 PM, Marek Vasut marex@denx.de wrote:
Dear Simon Glass,
+Joe (net maintainer) +Marek (USB)
Hi Suriyan,
On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami
suriyan.r@gmail.comwrote:
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by: “Suriyan Ramasami" suriyan.r@gmail.com
drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 15fd9a9..7bf0a34 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -14,6 +14,12 @@
/* SMSC LAN95xx based USB 2.0 Ethernet Devices */
+/* LED defines */ +#define LED_GPIO_CFG (0x24) +#define LED_GPIO_CFG_SPD_LED (0x01000000) +#define LED_GPIO_CFG_LNK_LED (0x00100000) +#define LED_GPIO_CFG_FDX_LED (0x00010000)
/* Tx command words */ #define TX_CMD_A_FIRST_SEG_ 0x00002000 #define TX_CMD_A_LAST_SEG_ 0x00001000
@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)
return ret; debug("ID_REV = 0x%08x\n", read_buf);
/* Configure GPIO pins as LED outputs */write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |LED_GPIO_CFG_FDX_LED;ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);if (ret < 0)return ret;debug("LED_GPIO_CFG set\n");Seems good.
Acked-by: Simon Glass sjg@chromium.org
Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Sure... When I need to be.
Heh :) Haven't seen you on IRC for a while (and you surely missed a lot, applied for sjg too). I picked this patch, so no problem here.
Best regards, Marek Vasut
participants (4)
-
Joe Hershberger -
Marek Vasut -
Simon Glass -
Suriyan Ramasami