[U-Boot] [PATCH] fit_image: Fix a double close() on the error path

There is an extra close() call which is not needed.
Reported-by: Coverity (CID: 143065) Signed-off-by: Simon Glass sjg@chromium.org ---
tools/fit_image.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/fit_image.c b/tools/fit_image.c index ddefa72..0551572 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -343,7 +343,6 @@ static int fit_build(struct image_tool_params *params, const char *fname) if (ret != size) { fprintf(stderr, "%s: Can't write %s: %s\n", params->cmdname, fname, strerror(errno)); - close(fd); goto err; } close(fd);

On Sun, May 01, 2016 at 05:12:24PM -0600, Simon Glass wrote:
There is an extra close() call which is not needed.
Reported-by: Coverity (CID: 143065) Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (2)
-
Simon Glass
-
Tom Rini