[U-Boot-Users] PATCH add SMN42 board from Siemens

Hi,
The patch is rather large and can be downloaded at ftp://ftp.denx.de/pub/patches/SMN42_NEW
The patch is against a u-boot tree checked out today at 14:35 (GMT+1).
Changes: 1) add cpu/arm720t/lpc2292 and include/asm-arm/arch-lpc2292 with files common to ports for the LPC2292. 2) patches to the lpc2292sodimm port reflecting (1). 3) errata fixes to board/lpc2292sodimm/eth.c obtained from Siemens. 4) add board/siemens/SMN42.
The eth.c files for lpc2292sodimm and SMN42 are identical, but the driver is very board-specific and cannot be put into e.g. drivers.
Signed-off-by: Gary Jennejohn garyj@denx.de

-----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces@lists.sourceforge.net] On Behalf Of Gary Jennejohn Sent: 03 April 2007 15:58 To: u-boot-users@lists.sourceforge.net Subject: [U-Boot-Users] PATCH add SMN42 board from Siemens
Hi,
The patch is rather large and can be downloaded at ftp://ftp.denx.de/pub/patches/SMN42_NEW
The eth.c files for lpc2292sodimm and SMN42 are identical, but the driver is very board-specific and cannot be put into e.g. drivers.
Gary
I stand ready to be corrected, but I thought the way round that was
a) move the eth.c to drivers/<unique name>.c b) add <unique_name>.o to the object list in drivers/Makefile c) encapsulate the code with #ifdef CONFIG_<UNIQUE_DEF> d) add #define CONFIG_<UNIQUE_DEF> to the include/configs/<board>.h for the lpc2292sodimm and SMN42 boards e) check I haven't missed anything from this list.....
see e.g drivers/smc91111.c used by DK1C20, DK1S10, EP1C20 etc
This might still be possible if the lpc2292sodimm and SMN42 eth.c differ slightly, using a board specific define.....
Regards
Peter
participants (2)
-
Gary Jennejohn
-
Peter Pearse