[U-Boot] [PATCH] libfdt: give setup.py optional interpreter

If building in a sandboxed environment where a alternate python interpreter is desired. Allow configuring of the PYTHON variable to specify the interpreter to invoke setup.py.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com --- tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index 77706a9..30505dc 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -136,7 +136,7 @@ tools/_libfdt.so: $(LIBFDT_SRCS) $(LIBFDT_SWIG) CPPFLAGS="$(_hostc_flags)" OBJDIR=tools \ SOURCES="$(LIBFDT_SRCS) tools/libfdt.i" \ SWIG_OPTS="-I$(srctree)/lib/libfdt -I$(srctree)/lib" \ - $(libfdt_tree)/pylibfdt/setup.py --quiet build_ext \ + $(PYTHON) $(libfdt_tree)/pylibfdt/setup.py --quiet build_ext \ --build-lib tools
ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)

Ben, All,
On Thu, Oct 12, 2017 at 9:32 PM, Matt Weber matthew.weber@rockwellcollins.com wrote:
If building in a sandboxed environment where a alternate python interpreter is desired. Allow configuring of the PYTHON variable to specify the interpreter to invoke setup.py.
Ignore, I was not against the latest codebase for this patch (used 2017.7 and noticed this was added in a commit on 2017.9.03).
There is still one piece missing and that's the check for SWIG (Makefile:237) should also use a variable we could override to look at an alternate location. Should I propose a patch?
Matt
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index 77706a9..30505dc 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -136,7 +136,7 @@ tools/_libfdt.so: $(LIBFDT_SRCS) $(LIBFDT_SWIG) CPPFLAGS="$(_hostc_flags)" OBJDIR=tools \ SOURCES="$(LIBFDT_SRCS) tools/libfdt.i" \ SWIG_OPTS="-I$(srctree)/lib/libfdt -I$(srctree)/lib" \
$(libfdt_tree)/pylibfdt/setup.py --quiet build_ext \
$(PYTHON) $(libfdt_tree)/pylibfdt/setup.py --quiet build_ext \ --build-lib tools
ifneq ($(CONFIG_MX23)$(CONFIG_MX28),)
1.8.3.1

On Thu, Oct 12, 2017 at 09:32:41PM -0500, Matt Weber wrote:
If building in a sandboxed environment where a alternate python interpreter is desired. Allow configuring of the PYTHON variable to specify the interpreter to invoke setup.py.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
Applied to u-boot/master, thanks!

On Mon, Oct 16, 2017 at 08:48:16PM -0400, Tom Rini wrote:
On Thu, Oct 12, 2017 at 09:32:41PM -0500, Matt Weber wrote:
If building in a sandboxed environment where a alternate python interpreter is desired. Allow configuring of the PYTHON variable to specify the interpreter to invoke setup.py.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
Applied to u-boot/master, thanks!
No, no it wasn't, bad me for not cleaning that out of my bundle after noticing it wasn't applicable and skipping it.

Tom,
On Mon, Oct 16, 2017 at 8:46 PM, Tom Rini trini@konsulko.com wrote:
On Mon, Oct 16, 2017 at 08:48:16PM -0400, Tom Rini wrote:
On Thu, Oct 12, 2017 at 09:32:41PM -0500, Matt Weber wrote:
If building in a sandboxed environment where a alternate python interpreter is desired. Allow configuring of the PYTHON variable to specify the interpreter to invoke setup.py.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
Applied to u-boot/master, thanks!
No, no it wasn't, bad me for not cleaning that out of my bundle after noticing it wasn't applicable and skipping it.
--
Should I send in a patch for the swig check update?
Matt

Tom,
On Tue, Oct 17, 2017 at 12:46 PM, Matthew Weber matthew.weber@rockwellcollins.com wrote:
Tom,
On Mon, Oct 16, 2017 at 8:46 PM, Tom Rini trini@konsulko.com wrote:
On Mon, Oct 16, 2017 at 08:48:16PM -0400, Tom Rini wrote:
On Thu, Oct 12, 2017 at 09:32:41PM -0500, Matt Weber wrote:
If building in a sandboxed environment where a alternate python interpreter is desired. Allow configuring of the PYTHON variable to specify the interpreter to invoke setup.py.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
Applied to u-boot/master, thanks!
No, no it wasn't, bad me for not cleaning that out of my bundle after noticing it wasn't applicable and skipping it.
--
Should I send in a patch for the swig check update?
Just noticed the recent patches. Disregard, I'll checkout the updated behavior.
participants (3)
-
Matt Weber
-
Matthew Weber
-
Tom Rini