[U-Boot] [PATCH v3 0/3] Trivial patches ready for merging

Hello,
I am resending the patches I think are ready to be applied and are trivial.
Please also add:
http://patchwork.ozlabs.org/patch/279105/
as it fixes a watchdog to work.
Changes in v3: - Fix code comment (dropped 'either')
Changes in v2: - rework commit log (Eric Benard) - rework commitlog (Fabio)
Otavio Salvador (3): mtd: Fix function description in part_validate comment include/linux/fb.h: Add a missing include for 'list.h' doc: Fix a typo in the description in doc/README.JFFS2_NAND
common/cmd_mtdparts.c | 7 +++---- doc/README.JFFS2_NAND | 2 +- include/linux/fb.h | 1 + 3 files changed, 5 insertions(+), 5 deletions(-)

The part_validate comment had a wrong description of the actions it does and referenced to non-existent functions while in fact it calls 'part_validate_eraseblock()'.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- Changes in v3: - Fix code comment (dropped 'either')
Changes in v2: - rework commit log (Eric Benard)
common/cmd_mtdparts.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c index 38a6e6d..f791372 100644 --- a/common/cmd_mtdparts.c +++ b/common/cmd_mtdparts.c @@ -381,10 +381,9 @@ static int part_validate_eraseblock(struct mtdids *id, struct part_info *part)
/** - * Performs sanity check for supplied partition. Offset and size are verified - * to be within valid range. Partition type is checked and either - * parts_validate_nor() or parts_validate_nand() is called with the argument - * of part. + * Performs sanity check for supplied partition. Offset and size are + * verified to be within valid range. Partition type is checked and + * part_validate_eraseblock() is called with the argument of part. * * @param id of the parent device * @param part partition to validate

On Thu, Oct 03, 2013 at 08:04:38AM -0300, Otavio Salvador wrote:
The part_validate comment had a wrong description of the actions it does and referenced to non-existent functions while in fact it calls 'part_validate_eraseblock()'.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Applied to u-boot/master, thanks!

The modelist data uses the list definition but the 'list.h' header were not being included. The build failure is bellow:
,---- | In file included from yyyy.c:16:0: | .../u-boot/include/linux/fb.h:503:19: error: field 'modelist' has incomplete type | struct list_head modelist; /* mode list */ | ^ | make[1]: *** [yyyy.o] Error 1 | make[1]: Leaving directory `.../u-boot/board/xxx/yyyy' | make: *** [board/xxx/yyyy/libyyyy.o] Error 2 `----
Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- Changes in v3: None Changes in v2: - rework commitlog (Fabio)
include/linux/fb.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/linux/fb.h b/include/linux/fb.h index 3858f8f..111372c 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -2,6 +2,7 @@ #define _LINUX_FB_H
#include <linux/types.h> +#include <linux/list.h>
/* Definitions of frame buffers */

On Thu, Oct 03, 2013 at 08:04:39AM -0300, Otavio Salvador wrote:
The modelist data uses the list definition but the 'list.h' header were not being included. The build failure is bellow:
,---- | In file included from yyyy.c:16:0: | .../u-boot/include/linux/fb.h:503:19: error: field 'modelist' has incomplete type | struct list_head modelist; /* mode list */ | ^ | make[1]: *** [yyyy.o] Error 1 | make[1]: Leaving directory `.../u-boot/board/xxx/yyyy' | make: *** [board/xxx/yyyy/libyyyy.o] Error 2 `----
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Applied to u-boot/master, thanks!

Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- Changes in v3: None Changes in v2: None
doc/README.JFFS2_NAND | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/README.JFFS2_NAND b/doc/README.JFFS2_NAND index 5018ae8..09788d5 100644 --- a/doc/README.JFFS2_NAND +++ b/doc/README.JFFS2_NAND @@ -1,6 +1,6 @@ JFFS2 NAND support:
-To ebable, use the following #define in the board configuration file: +To enable, use the following #define in the board configuration file:
#define CONFIG_JFFS2_NAND 1

On Thu, Oct 03, 2013 at 08:04:40AM -0300, Otavio Salvador wrote:
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Changes in v3: None Changes in v2: None
doc/README.JFFS2_NAND | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/README.JFFS2_NAND b/doc/README.JFFS2_NAND index 5018ae8..09788d5 100644 --- a/doc/README.JFFS2_NAND +++ b/doc/README.JFFS2_NAND @@ -1,6 +1,6 @@ JFFS2 NAND support:
-To ebable, use the following #define in the board configuration file: +To enable, use the following #define in the board configuration file:
#define CONFIG_JFFS2_NAND 1
Applied to u-boot/master, thanks!
participants (2)
-
Otavio Salvador
-
Tom Rini