[U-Boot] [PATCH v2] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Make it clear to the reader that, since OMAP 34XX and 35XX are the same silicon, the BeagleBoard can use the OMAP34XX macros.
Signed-off-by: Robert P. J. Day rpjday@crashcourse.ca
---
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index 19a5ec9..59b7edc 100644 --- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -30,6 +30,9 @@
/* * High Level Configuration Options + * + * Note that since OMAP 34XX and 35XX are the same silicon, the + * OMAP 3530-based BeagleBoard can use the OMAP34XX macros. */ #define CONFIG_ARMCORTEXA8 1 /* This is an ARM V7 CPU core */ #define CONFIG_OMAP 1 /* in a TI OMAP core */
======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================
Robert P. J. Day wrote:
Make it clear to the reader that, since OMAP 34XX and 35XX are the same silicon, the BeagleBoard can use the OMAP34XX macros.
Signed-off-by: Robert P. J. Day rpjday@crashcourse.ca
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index 19a5ec9..59b7edc 100644 --- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -30,6 +30,9 @@
/*
- High Level Configuration Options
- Note that since OMAP 34XX and 35XX are the same silicon, the
- OMAP 3530-based BeagleBoard can use the OMAP34XX macros.
I think this comment would be appropriate in the omap3 readme.
<beyond_scope_of_change> Perhaps the omap3 specific defines could be explained in greater detail there. </beyond_scope_of_change>
Tom
*/ #define CONFIG_ARMCORTEXA8 1 /* This is an ARM V7 CPU core */ #define CONFIG_OMAP 1 /* in a TI OMAP core */
======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ======================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Fri, 20 Nov 2009, Tom wrote:
Robert P. J. Day wrote:
Make it clear to the reader that, since OMAP 34XX and 35XX are the same silicon, the BeagleBoard can use the OMAP34XX macros.
Signed-off-by: Robert P. J. Day rpjday@crashcourse.ca
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index 19a5ec9..59b7edc 100644 --- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -30,6 +30,9 @@
/*
- High Level Configuration Options
- Note that since OMAP 34XX and 35XX are the same silicon, the
- OMAP 3530-based BeagleBoard can use the OMAP34XX macros.
I think this comment would be appropriate in the omap3 readme.
<beyond_scope_of_change> Perhaps the omap3 specific defines could be explained in greater detail there. </beyond_scope_of_change>
certainly, there's nothing amiss about a longer explanation in the README file. but the rationale for the above was just a couple lines to prevent any confusion on the part of anyone who wanted to peruse the beagle config file, nothing more. it wasn't meant to be a big deal.
rday --
======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================
participants (2)
-
Robert P. J. Day -
Tom