[U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow
When we have an excess size growth, fix the "limit" printf call to pass in just the limit variable rather than the string bytes to the format character.
Signed-off-by: Tom Rini trini@konsulko.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index cbacf1cfe2c9..f09023a3977f 100644 --- a/Makefile +++ b/Makefile @@ -346,7 +346,7 @@ define size_check limit=$$( printf "%d" $2 ); \ if test $$actual -gt $$limit; then \ echo "$1 exceeds file size limit:" >&2; \ - echo " limit: $$(printf %#x bytes $$limit) bytes" >&2; \ + echo " limit: $$(printf %#x $$limit) bytes" >&2; \ echo " actual: $$(printf %#x $$actual) bytes" >&2; \ echo " excess: $$(printf %#x $$((actual - limit))) bytes" >&2;\ exit 1; \
Am 23.10.2019 um 21:39 schrieb Tom Rini:
When we have an excess size growth, fix the "limit" printf call to pass in just the limit variable rather than the string bytes to the format character.
Signed-off-by: Tom Rini trini@konsulko.com
Reviewed-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index cbacf1cfe2c9..f09023a3977f 100644 --- a/Makefile +++ b/Makefile @@ -346,7 +346,7 @@ define size_check limit=$$( printf "%d" $2 ); \ if test $$actual -gt $$limit; then \ echo "$1 exceeds file size limit:" >&2; \
echo " limit: $$(printf %#x bytes $$limit) bytes" >&2; \
echo " limit: $$(printf %#x $$limit) bytes" >&2; \
On Wed, Oct 23, 2019 at 03:39:41PM -0400, Tom Rini wrote:
When we have an excess size growth, fix the "limit" printf call to pass in just the limit variable rather than the string bytes to the format character.
Signed-off-by: Tom Rini trini@konsulko.com Reviewed-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
Applied to u-boot/master, thanks!
participants (2)
-
Simon Goldschmidt -
Tom Rini