[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com --- drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index bbd547b..7a55638 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, req->requesttype, req->requesttype, le16_to_cpu(req->value), le16_to_cpu(req->index));
- typeReq = req->request << 8 | req->requesttype; + typeReq = req->request | req->requesttype << 8;
switch (le16_to_cpu(typeReq)) { case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index bbd547b..7a55638 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, req->requesttype, req->requesttype, le16_to_cpu(req->value), le16_to_cpu(req->index));
- typeReq = req->request << 8 | req->requesttype;
- typeReq = req->request | req->requesttype << 8;
Sorry, but I'm not sure in this inversion. Are your sure?
switch (le16_to_cpu(typeReq)) {
Maybe this one has no sense... Michael
case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
-----Original Message----- From: Michael Trimarchi [mailto:trimarchi@gandalf.sssup.it] Sent: Monday, June 29, 2009 5:48 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c
b/drivers/usb/host/ehci-hcd.c
index bbd547b..7a55638 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device
*dev, unsigned long pipe, void *buffer,
req->requesttype, req->requesttype, le16_to_cpu(req->value), le16_to_cpu(req->index));
- typeReq = req->request << 8 | req->requesttype;
- typeReq = req->request | req->requesttype << 8;
Sorry, but I'm not sure in this inversion. Are your sure?
Hi Michael
I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.
Regards.. Prafulla . .
Prafulla Wadaskar wrote:
-----Original Message----- From: Michael Trimarchi [mailto:trimarchi@gandalf.sssup.it] Sent: Monday, June 29, 2009 5:48 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c
b/drivers/usb/host/ehci-hcd.c
index bbd547b..7a55638 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device
*dev, unsigned long pipe, void *buffer,
req->requesttype, req->requesttype, le16_to_cpu(req->value), le16_to_cpu(req->index));
- typeReq = req->request << 8 | req->requesttype;
- typeReq = req->request | req->requesttype << 8;
Sorry, but I'm not sure in this inversion. Are your sure?
Hi Michael
I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.
Regards.. Prafulla . .
Yes, I have drinked somenthing today :(. Linux do the same
typeReq = (cmd->bRequestType << 8) | cmd->bRequest;
Sorry Michael
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
Best Regards, J.
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Best Regards, J. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Hello All,
2009/7/4 Michael Trimarchi trimarchi@gandalf.sssup.it:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Sorry for not being very responsive these days... it is vacation time... ;-)
This patch of Michael looks good, and I prefer that patch above the marvell usb patch. If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)
Kind Regards,
Remy
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Remy Bohmer Sent: Wednesday, July 08, 2009 12:16 AM To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Hello All,
2009/7/4 Michael Trimarchi trimarchi@gandalf.sssup.it:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Sorry for not being very responsive these days... it is vacation time... ;-)
This patch of Michael looks good, and I prefer that patch above the marvell usb patch.
Patch by me ;-D
If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)
Hi Kumar I have seen a patch by you to this file Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html I hope you have h/w and tested ehci-hcd driver :-) Can you pls comment on this? FYI: I have tested it for Sheevaplug Kirkwood hardware If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)
I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??
Regards.. Prafulla . .
Kind Regards,
Remy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Prafulla Wadaskar wrote:
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Remy Bohmer Sent: Wednesday, July 08, 2009 12:16 AM To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Hello All,
2009/7/4 Michael Trimarchi trimarchi@gandalf.sssup.it:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Sorry for not being very responsive these days... it is vacation time... ;-)
This patch of Michael looks good, and I prefer that patch above the marvell usb patch.
Patch by me ;-D
If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)
Hi Kumar I have seen a patch by you to this file Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html I hope you have h/w and tested ehci-hcd driver :-) Can you pls comment on this? FYI: I have tested it for Sheevaplug Kirkwood hardware If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)
I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??
Because there was an error in the switch :( maybe, that I fix in my patch, but I can't test now because I don't have any hardware.
- typeReq = req->request << 8 | req->requesttype; + typeReq = req->request | req->requesttype << 8;
- switch (le16_to_cpu(typeReq)) { + switch (typeReq) {
Michael
Regards.. Prafulla . .
Kind Regards,
Remy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Jul 8, 2009, at 1:44 AM, Michael Trimarchi wrote:
Prafulla Wadaskar wrote:
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de ] On Behalf Of Remy Bohmer Sent: Wednesday, July 08, 2009 12:16 AM To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci- hcd.c function ehci_submit_root
Hello All,
2009/7/4 Michael Trimarchi trimarchi@gandalf.sssup.it:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Sorry for not being very responsive these days... it is vacation time... ;-)
This patch of Michael looks good, and I prefer that patch above the marvell usb patch.
Patch by me ;-D
If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)
Hi Kumar I have seen a patch by you to this file Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html I hope you have h/w and tested ehci-hcd driver :-) Can you pls comment on this? FYI: I have tested it for Sheevaplug Kirkwood hardware If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/ hcd.c)
I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??
Because there was an error in the switch :( maybe, that I fix in my patch, but I can't test now because I don't have any hardware.
- typeReq = req->request << 8 | req->requesttype;
- typeReq = req->request | req->requesttype << 8;
- switch (le16_to_cpu(typeReq)) {
- switch (typeReq) {
I'm quite confused by this.. I was just fixing some warnings from the fact that we did some read's but never used the results. If that code has changed (or is going to) than my patch is not needed. I don't think the patch I posted has any side effects beyond getting rid of the warnings.
- k
-----Original Message----- From: Kumar Gala [mailto:galak@kernel.crashing.org] Sent: Wednesday, July 08, 2009 7:43 PM To: Michael Trimarchi Cc: Prafulla Wadaskar; Remy Bohmer; u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
On Jul 8, 2009, at 1:44 AM, Michael Trimarchi wrote:
Prafulla Wadaskar wrote:
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de ] On Behalf Of Remy Bohmer Sent: Wednesday, July 08, 2009 12:16 AM To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix
driver/usb/host/ehci-
hcd.c function ehci_submit_root
Hello All,
2009/7/4 Michael Trimarchi trimarchi@gandalf.sssup.it:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
> Signed-off-by: Prafulla Wadaskar prafulla@marvell.com > --- > drivers/usb/host/ehci-hcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Sorry for not being very responsive these days... it is vacation time... ;-)
This patch of Michael looks good, and I prefer that patch
above the
marvell usb patch.
Patch by me ;-D
If anybody of you are able of testing it, I can apply it.
(I do not
have the proper hardware myself)
Dear Remy This patch is last dependency to enable Kirkwood Sheevaplug board support. And I think, nobody else has tested it. Please kindly apply it before sending pull request for usb.
Regards.. Prafulla . .
Hi Kumar I have seen a patch by you to this file Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html I hope you have h/w and tested ehci-hcd driver :-) Can you pls comment on this? FYI: I have tested it for Sheevaplug Kirkwood hardware If
you get a
chance, pls go through my patch, I feel it is logical and
even in the
kernel too. (ref: line 379: linux/drivers/usb/core/ hcd.c)
I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??
Because there was an error in the switch :( maybe, that I fix in my patch, but I can't test now because I don't have any hardware.
- typeReq = req->request << 8 | req->requesttype;
- typeReq = req->request | req->requesttype << 8;
- switch (le16_to_cpu(typeReq)) {
- switch (typeReq) {
I'm quite confused by this.. I was just fixing some warnings from the fact that we did some read's but never used the results. If that code has changed (or is going to) than my patch is not needed. I don't think the patch I posted has any side effects beyond getting rid of the warnings.
- k
-----Original Message----- From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@jcrosoft.com] Sent: Saturday, July 04, 2009 5:17 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
Dear Remy Gentle reminder. Regards.. Prafulla . .
Best Regards, J.
participants (5)
-
Jean-Christophe PLAGNIOL-VILLARD -
Kumar Gala -
Michael Trimarchi -
Prafulla Wadaskar -
Remy Bohmer