[PATCH 1/2] mmc: stm32_sdmmc2: Add "st,stm32mp25-sdmmc2" compatible
From: Patrick Delaunay patrick.delaunay@foss.st.com
Add compatible used for STM32MP25 family.
Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com ---
drivers/mmc/stm32_sdmmc2.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index a2b111a8435..d4982a14281 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -789,6 +789,7 @@ static int stm32_sdmmc2_bind(struct udevice *dev)
static const struct udevice_id stm32_sdmmc2_ids[] = { { .compatible = "st,stm32-sdmmc2" }, + { .compatible = "st,stm32mp25-sdmmc2" }, { } };
When building with AARCH64 defconfig, we got warnings, fix them.
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com ---
drivers/mmc/stm32_sdmmc2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index d4982a14281..39ae79ba129 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -220,9 +220,9 @@ static void stm32_sdmmc2_start_data(struct udevice *dev,
if (data->flags & MMC_DATA_READ) { data_ctrl |= SDMMC_DCTRL_DTDIR; - idmabase0 = (u32)data->dest; + idmabase0 = (u32)(long)data->dest; } else { - idmabase0 = (u32)data->src; + idmabase0 = (u32)(long)data->src; }
/* Set the SDMMC DataLength value */ @@ -463,8 +463,8 @@ retry_cmd:
stm32_sdmmc2_start_cmd(dev, cmd, cmdat, &ctx);
- dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%x\n", - cmd->cmdidx, data ? ctx.data_length : 0, (unsigned int)data); + dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%p\n", + cmd->cmdidx, data ? ctx.data_length : 0, data);
ret = stm32_sdmmc2_end_cmd(dev, cmd, &ctx);
Hi,
On 3/8/24 15:26, Patrice Chotard wrote:
When building with AARCH64 defconfig, we got warnings, fix them.
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
drivers/mmc/stm32_sdmmc2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index d4982a14281..39ae79ba129 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -220,9 +220,9 @@ static void stm32_sdmmc2_start_data(struct udevice *dev,
if (data->flags & MMC_DATA_READ) { data_ctrl |= SDMMC_DCTRL_DTDIR;
idmabase0 = (u32)data->dest;
idmabase0 = (u32)(long)data->dest;
idmabase0 = (u32)data->src;
idmabase0 = (u32)(long)data->src;}
/* Set the SDMMC DataLength value */
@@ -463,8 +463,8 @@ retry_cmd:
stm32_sdmmc2_start_cmd(dev, cmd, cmdat, &ctx);
- dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%x\n",
cmd->cmdidx, data ? ctx.data_length : 0, (unsigned int)data);
dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%p\n",
cmd->cmdidx, data ? ctx.data_length : 0, data);ret = stm32_sdmmc2_end_cmd(dev, cmd, &ctx);
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Thanks Patrick
-----Original Message----- From: Patrick DELAUNAY patrick.delaunay@foss.st.com Sent: Wednesday, April 17, 2024 6:02 PM To: Patrice Chotard patrice.chotard@foss.st.com; u-boot@lists.denx.de Cc: U-Boot STM32 uboot-stm32@st-md-mailman.stormreply.com; Jaehoon Chung jh80.chung@samsung.com; Peng Fan peng.fan@nxp.com; Sean Anderson seanga2@gmail.com; Simon Glass sjg@chromium.org; Tom Rini trini@konsulko.com Subject: Re: [PATCH 2/2] mmc: stm32_sdmmc2: Fix AARCH64 compilation warnings
Hi,
On 3/8/24 15:26, Patrice Chotard wrote:
When building with AARCH64 defconfig, we got warnings, fix them.
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
drivers/mmc/stm32_sdmmc2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index d4982a14281..39ae79ba129 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -220,9 +220,9 @@ static void stm32_sdmmc2_start_data(struct udevice *dev,
if (data->flags & MMC_DATA_READ) { data_ctrl |= SDMMC_DCTRL_DTDIR;
idmabase0 = (u32)data->dest;
idmabase0 = (u32)(long)data->dest;
idmabase0 = (u32)data->src;
idmabase0 = (u32)(long)data->src;}
/* Set the SDMMC DataLength value */
@@ -463,8 +463,8 @@ retry_cmd:
stm32_sdmmc2_start_cmd(dev, cmd, cmdat, &ctx);
- dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%x\n",
cmd->cmdidx, data ? ctx.data_length : 0, (unsigned int)data);
dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%p\n",
cmd->cmdidx, data ? ctx.data_length : 0, data);ret = stm32_sdmmc2_end_cmd(dev, cmd, &ctx);
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Thanks Patrick
On 4/17/24 13:11, Jaehoon Chung wrote:
-----Original Message----- From: Patrick DELAUNAY patrick.delaunay@foss.st.com Sent: Wednesday, April 17, 2024 6:02 PM To: Patrice Chotard patrice.chotard@foss.st.com; u-boot@lists.denx.de Cc: U-Boot STM32 uboot-stm32@st-md-mailman.stormreply.com; Jaehoon Chung jh80.chung@samsung.com; Peng Fan peng.fan@nxp.com; Sean Anderson seanga2@gmail.com; Simon Glass sjg@chromium.org; Tom Rini trini@konsulko.com Subject: Re: [PATCH 2/2] mmc: stm32_sdmmc2: Fix AARCH64 compilation warnings
Hi,
On 3/8/24 15:26, Patrice Chotard wrote:
When building with AARCH64 defconfig, we got warnings, fix them.
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
drivers/mmc/stm32_sdmmc2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index d4982a14281..39ae79ba129 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -220,9 +220,9 @@ static void stm32_sdmmc2_start_data(struct udevice *dev,
if (data->flags & MMC_DATA_READ) { data_ctrl |= SDMMC_DCTRL_DTDIR;
idmabase0 = (u32)data->dest;
idmabase0 = (u32)(long)data->dest;
idmabase0 = (u32)data->src;
idmabase0 = (u32)(long)data->src;}
/* Set the SDMMC DataLength value */
@@ -463,8 +463,8 @@ retry_cmd:
stm32_sdmmc2_start_cmd(dev, cmd, cmdat, &ctx);
- dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%x\n",
cmd->cmdidx, data ? ctx.data_length : 0, (unsigned int)data);
dev_dbg(dev, "send cmd %d data: 0x%x @ 0x%p\n",
cmd->cmdidx, data ? ctx.data_length : 0, data);ret = stm32_sdmmc2_end_cmd(dev, cmd, &ctx);
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Thanks Patrick
Applied on u-boot-stm32/master
Hi,
On 3/8/24 15:26, Patrice Chotard wrote:
From: Patrick Delaunay patrick.delaunay@foss.st.com
Add compatible used for STM32MP25 family.
Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
drivers/mmc/stm32_sdmmc2.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index a2b111a8435..d4982a14281 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -789,6 +789,7 @@ static int stm32_sdmmc2_bind(struct udevice *dev)
static const struct udevice_id stm32_sdmmc2_ids[] = { { .compatible = "st,stm32-sdmmc2" },
- { .compatible = "st,stm32mp25-sdmmc2" }, { } };
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Thanks Patrick
Hi
-----Original Message----- From: Patrick DELAUNAY patrick.delaunay@foss.st.com Sent: Wednesday, April 17, 2024 6:02 PM To: Patrice Chotard patrice.chotard@foss.st.com; u-boot@lists.denx.de Cc: U-Boot STM32 uboot-stm32@st-md-mailman.stormreply.com; Jaehoon Chung jh80.chung@samsung.com; Peng Fan peng.fan@nxp.com; Sean Anderson seanga2@gmail.com; Simon Glass sjg@chromium.org; Tom Rini trini@konsulko.com Subject: Re: [PATCH 1/2] mmc: stm32_sdmmc2: Add "st,stm32mp25-sdmmc2" compatible
Hi,
On 3/8/24 15:26, Patrice Chotard wrote:
From: Patrick Delaunay patrick.delaunay@foss.st.com
Add compatible used for STM32MP25 family.
Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
drivers/mmc/stm32_sdmmc2.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index a2b111a8435..d4982a14281 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -789,6 +789,7 @@ static int stm32_sdmmc2_bind(struct udevice *dev)
static const struct udevice_id stm32_sdmmc2_ids[] = { { .compatible = "st,stm32-sdmmc2" },
- { .compatible = "st,stm32mp25-sdmmc2" }, { } };
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Thanks Patrick
On 4/17/24 13:10, Jaehoon Chung wrote:
Hi
-----Original Message----- From: Patrick DELAUNAY patrick.delaunay@foss.st.com Sent: Wednesday, April 17, 2024 6:02 PM To: Patrice Chotard patrice.chotard@foss.st.com; u-boot@lists.denx.de Cc: U-Boot STM32 uboot-stm32@st-md-mailman.stormreply.com; Jaehoon Chung jh80.chung@samsung.com; Peng Fan peng.fan@nxp.com; Sean Anderson seanga2@gmail.com; Simon Glass sjg@chromium.org; Tom Rini trini@konsulko.com Subject: Re: [PATCH 1/2] mmc: stm32_sdmmc2: Add "st,stm32mp25-sdmmc2" compatible
Hi,
On 3/8/24 15:26, Patrice Chotard wrote:
From: Patrick Delaunay patrick.delaunay@foss.st.com
Add compatible used for STM32MP25 family.
Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
drivers/mmc/stm32_sdmmc2.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index a2b111a8435..d4982a14281 100644 --- a/drivers/mmc/stm32_sdmmc2.c +++ b/drivers/mmc/stm32_sdmmc2.c @@ -789,6 +789,7 @@ static int stm32_sdmmc2_bind(struct udevice *dev)
static const struct udevice_id stm32_sdmmc2_ids[] = { { .compatible = "st,stm32-sdmmc2" },
- { .compatible = "st,stm32mp25-sdmmc2" }, { } };
Reviewed-by: Patrick Delaunay patrick.delaunay@foss.st.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Thanks Patrick
Applied on u-boot-stm32/master
participants (4)
-
Jaehoon Chung -
Patrice CHOTARD -
Patrice Chotard
-
Patrick DELAUNAY