[PATCH] configs/ethernut5.h: define CFG_SYS_I2C_RTC_ADDR unconditionally
The PCF6563 RTC driver needs the I2C address of the chip on the board to be defined as CFG_SYS_I2C_RTC_ADDR. ethernut5 selects this driver but defines CFG_SYS_I2C_RTC_ADDR only when CMD_DATE or CMD_SNTP is enabled which is clearly wrong. The condition should be on the driver's Kconfig instead (#ifdef CONFIG_RTC_PCF8563), but there is no harm in defining the symbol even when the driver is not selected, as all other boards do. So just remove the condition.
Signed-off-by: Jerome Forissier jerome.forissier@linaro.org --- include/configs/ethernut5.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/ethernut5.h b/include/configs/ethernut5.h index c327bbbe07d..338306dfe08 100644 --- a/include/configs/ethernut5.h +++ b/include/configs/ethernut5.h @@ -55,9 +55,7 @@ #endif
/* RTC */ -#if defined(CONFIG_CMD_DATE) || defined(CONFIG_CMD_SNTP) #define CFG_SYS_I2C_RTC_ADDR 0x51 -#endif
#define I2C_SOFT_DECLARATIONS
Tom,
I wonder if it makes sense just to drop this board altogether? I looked at it for some other unloved feature at the beginning of the year and I never heard from the maintainers.
Peter
On Mon, 2 Sept 2024 at 14:13, Jerome Forissier jerome.forissier@linaro.org wrote:
The PCF6563 RTC driver needs the I2C address of the chip on the board to be defined as CFG_SYS_I2C_RTC_ADDR. ethernut5 selects this driver but defines CFG_SYS_I2C_RTC_ADDR only when CMD_DATE or CMD_SNTP is enabled which is clearly wrong. The condition should be on the driver's Kconfig instead (#ifdef CONFIG_RTC_PCF8563), but there is no harm in defining the symbol even when the driver is not selected, as all other boards do. So just remove the condition.
Signed-off-by: Jerome Forissier jerome.forissier@linaro.org
include/configs/ethernut5.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/ethernut5.h b/include/configs/ethernut5.h index c327bbbe07d..338306dfe08 100644 --- a/include/configs/ethernut5.h +++ b/include/configs/ethernut5.h @@ -55,9 +55,7 @@ #endif
/* RTC */ -#if defined(CONFIG_CMD_DATE) || defined(CONFIG_CMD_SNTP) #define CFG_SYS_I2C_RTC_ADDR 0x51 -#endif
#define I2C_SOFT_DECLARATIONS
-- 2.40.1
On Mon, Sep 02, 2024 at 02:19:04PM +0100, Peter Robinson wrote:
Tom,
I wonder if it makes sense just to drop this board altogether? I looked at it for some other unloved feature at the beginning of the year and I never heard from the maintainers.
That doesn't sound unreasonable, unless the maintainers chime in?
Peter
On Mon, 2 Sept 2024 at 14:13, Jerome Forissier jerome.forissier@linaro.org wrote:
The PCF6563 RTC driver needs the I2C address of the chip on the board to be defined as CFG_SYS_I2C_RTC_ADDR. ethernut5 selects this driver but defines CFG_SYS_I2C_RTC_ADDR only when CMD_DATE or CMD_SNTP is enabled which is clearly wrong. The condition should be on the driver's Kconfig instead (#ifdef CONFIG_RTC_PCF8563), but there is no harm in defining the symbol even when the driver is not selected, as all other boards do. So just remove the condition.
Signed-off-by: Jerome Forissier jerome.forissier@linaro.org
include/configs/ethernut5.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/ethernut5.h b/include/configs/ethernut5.h index c327bbbe07d..338306dfe08 100644 --- a/include/configs/ethernut5.h +++ b/include/configs/ethernut5.h @@ -55,9 +55,7 @@ #endif
/* RTC */ -#if defined(CONFIG_CMD_DATE) || defined(CONFIG_CMD_SNTP) #define CFG_SYS_I2C_RTC_ADDR 0x51 -#endif
#define I2C_SOFT_DECLARATIONS
-- 2.40.1
participants (3)
-
Jerome Forissier -
Peter Robinson -
Tom Rini