On 7/30/24 12:42, Michal Simek wrote:

Having zynqmp firmware is actually only one valid configuration. In QEMU case for example there is no PMU that's why this checking can't end up in panic that's why code remove this code completely.

Signed-off-by: Michal Simek michal.simek@amd.com

board/xilinx/zynqmp/zynqmp.c | 13 ------------- 1 file changed, 13 deletions(-)

diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c index b4c15b041ccb..e6331c0e4d81 100644 --- a/board/xilinx/zynqmp/zynqmp.c +++ b/board/xilinx/zynqmp/zynqmp.c @@ -152,20 +152,7 @@ int board_init(void) if (sizeof(CONFIG_ZYNQMP_SPL_PM_CFG_OBJ_FILE) > 1) zynqmp_pmufw_load_config_object(zynqmp_pm_cfg_obj, zynqmp_pm_cfg_obj_size); -#endif

-#if defined(CONFIG_ZYNQMP_FIRMWARE)

• struct udevice *dev;

• uclass_get_device_by_name(UCLASS_FIRMWARE, "power-management", &dev);

• if (!dev) {

• uclass_get_device_by_name(UCLASS_FIRMWARE, "zynqmp-power", &dev);
  

• if (!dev)
  

• 	panic("PMU Firmware device not found - Enable it");
  

• }

-#endif

-#if defined(CONFIG_SPL_BUILD) printf("Silicon version:\t%d\n", zynqmp_get_silicon_version());

/* the CSU disables the JTAG interface when secure boot is enabled */

Applied. M