[U-Boot] [PATCH MAKEALL coldfire] : Fix start.S:Error: Conversion of PC relative displacement to absolute

newer
[U-Boot] [PATCH][v1] FDT: remove...

Philippe De Muyter

21 Sep 2009 21 Sep '09

9:49 p.m.

Hi all,

This fixes the following errors when running MAKEALL for coldfire : start.S: Assembler messages: start.S:320: Error: Conversion of PC relative displacement to absolute

Signed-off-by: Philippe De Muyter phdm@macqel.be

diff -ru a/cpu/mcf523x/start.S b/cpu/mcf523x/start.S --- a/cpu/mcf523x/start.S 2009-09-17 23:28:31.000000000 +0200 +++ b/cpu/mcf523x/start.S 2009-09-21 19:58:34.000000000 +0200 @@ -246,7 +246,7 @@ /* exception code */ .globl _fault _fault: - jmp _fault + bra _fault .globl _exc_handler

_exc_handler: diff -ru a/cpu/mcf52x2/start.S b/cpu/mcf52x2/start.S --- a/cpu/mcf52x2/start.S 2009-09-17 23:28:31.000000000 +0200 +++ b/cpu/mcf52x2/start.S 2009-09-21 19:47:40.000000000 +0200 @@ -317,7 +317,7 @@ /* exception code */ .globl _fault _fault: - jmp _fault + bra _fault

.globl _exc_handler _exc_handler: diff -ru a/cpu/mcf532x/start.S b/cpu/mcf532x/start.S --- a/cpu/mcf532x/start.S 2009-09-17 23:28:31.000000000 +0200 +++ b/cpu/mcf532x/start.S 2009-09-21 19:50:36.000000000 +0200 @@ -256,7 +256,7 @@ /* exception code */ .globl _fault _fault: - jmp _fault + bra _fault .globl _exc_handler

_exc_handler:

Show replies by date

Philippe De Muyter

21 Sep 21 Sep

10:06 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] fix tools/kwbimage.c format warning

Hi all,

This fixes the following warnings when running MAKEALL for coldfire : tools/kwbimage.c: In function #kwbimage_checksum32#: tools/kwbimage.c:135: warning: format #%ld# expects type #long int#, but argument 4 has type #unsigned int#

Signed-off-by: Philippe De Muyter phdm@macqel.be

diff -ru a/tools/kwbimage.c b/tools/kwbimage.c --- a/tools/kwbimage.c 2009-09-17 23:28:31.000000000 +0200 +++ b/tools/kwbimage.c 2009-09-21 19:40:19.000000000 +0200 @@ -131,7 +131,7 @@ return 0;

if (len % sizeof(uint32_t)) { - printf ("Error:%s[%d] - lenght is not in multiple of %ld\n", + printf ("Error:%s[%d] - length is not in multiple of %u\n", __FUNCTION__, len, sizeof(uint32_t)); return 0; }

Wolfgang Denk

10:16 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] fix tools/kwbimage.c format warning

Dear Philippe De Muyter,

In message 20090921200644.GA6670@frolo.macqel you wrote:

...

Hi all,

This fixes the following warnings when running MAKEALL for coldfire : tools/kwbimage.c: In function #kwbimage_checksum32#: tools/kwbimage.c:135: warning: format #%ld# expects type #long int#, but argument 4 has type #unsigned int#

Signed-off-by: Philippe De Muyter phdm@macqel.be

diff -ru a/tools/kwbimage.c b/tools/kwbimage.c --- a/tools/kwbimage.c 2009-09-17 23:28:31.000000000 +0200 +++ b/tools/kwbimage.c 2009-09-21 19:40:19.000000000 +0200 @@ -131,7 +131,7 @@ return 0;

if (len % sizeof(uint32_t)) {
printf ("Error:%s[%d] - lenght is not in multiple of %ld\n",
printf ("Error:%s[%d] - length is not in multiple of %u\n",
__FUNCTION__, len, sizeof(uint32_t));

Seems you are using old code. This has long been fixed (using a %zu format).

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Men don't talk peace unless they're ready to back it up with war. -- Col. Green, "The Savage Curtain", stardate 5906.4

Philippe De Muyter

10:28 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] fix tools/kwbimage.c format warning

On Mon, Sep 21, 2009 at 10:16:21PM +0200, Wolfgang Denk wrote:

...

Dear Philippe De Muyter,

In message 20090921200644.GA6670@frolo.macqel you wrote:

...
Hi all,

This fixes the following warnings when running MAKEALL for coldfire : tools/kwbimage.c: In function #kwbimage_checksum32#: tools/kwbimage.c:135: warning: format #%ld# expects type #long int#, but argument 4 has type #unsigned int#

Signed-off-by: Philippe De Muyter phdm@macqel.be

diff -ru a/tools/kwbimage.c b/tools/kwbimage.c --- a/tools/kwbimage.c 2009-09-17 23:28:31.000000000 +0200 +++ b/tools/kwbimage.c 2009-09-21 19:40:19.000000000 +0200 @@ -131,7 +131,7 @@ return 0;

if (len % sizeof(uint32_t)) {
printf ("Error:%s[%d] - lenght is not in multiple of %ld\n",
printf ("Error:%s[%d] - length is not in multiple of %u\n",
__FUNCTION__, len, sizeof(uint32_t));
Seems you are using old code. This has long been fixed (using a %zu format).

That's surprising. I got a tarball last friday (3 days ago) using the snapshot button on the gitweb interface :

u-boot-3dc5e00454a58499d4f4c790b38036b0e873747e.tar.gz

Best regards

Philippe

Wolfgang Denk

10:53 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] fix tools/kwbimage.c format warning

Dear Philippe De Muyter,

In message 20090921202802.GB12703@frolo.macqel you wrote:

...

...
...
if (len % sizeof(uint32_t)) {
printf ("Error:%s[%d] - lenght is not in multiple of %ld\n",
printf ("Error:%s[%d] - length is not in multiple of %u\n",
__FUNCTION__, len, sizeof(uint32_t));
Seems you are using old code. This has long been fixed (using a %zu format).
That's surprising. I got a tarball last friday (3 days ago) using the snapshot button on the gitweb interface :

u-boot-3dc5e00454a58499d4f4c790b38036b0e873747e.tar.gz

You need this commit:

commit ceb2d57c2205db5bbd868577f756c74a2568160c Author: Wolfgang Denk wd@denx.de Date: Tue Sep 15 21:13:27 2009 +0200

kwbimage.c: Fix compile warning when building on 64 bit systems (again)

Commit 51003b89 attempted to fix a build problem on 64 bit systems, but just turned it into a build problem on 32 bit systems (silly me).

Now do the Right Thing (TM) and use a "%zu" printf format.

Also fix spelling error.

Signed-off-by: Wolfgang Denk wd@denx.de

It was merged into the master branch on 2009-09-18 23:20:12.

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de What is mind? No matter. What is matter? Never mind. -- Thomas Hewitt Key, 1799-1875

Philippe De Muyter

11:08 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] fix tools/kwbimage.c format warning

Dear Wolfgang,

On Mon, Sep 21, 2009 at 10:53:13PM +0200, Wolfgang Denk wrote:

...

...
...
Seems you are using old code. This has long been fixed (using a %zu format).

That's surprising. I got a tarball last friday (3 days ago) using the snapshot button on the gitweb interface :

u-boot-3dc5e00454a58499d4f4c790b38036b0e873747e.tar.gz

You need this commit: ... Date: Tue Sep 15 21:13:27 2009 +0200 ... It was merged into the master branch on 2009-09-18 23:20:12.

OK, that's the explanation : I downloaded the snapshot on 2009-09-18 18:59

thanks and good night

Philippe

Philippe De Muyter

10:20 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] fix cmd_bdinfo.c:354: warning: 'print_eth' defined but not used

Hi all,

This fixes the following warnings when running MAKEALL for coldfire : cmd_bdinfo.c:354: warning: 'print_eth' defined but not used

Signed-off-by: Philippe De Muyter phdm@macqel.be

diff -ru a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c --- a/common/cmd_bdinfo.c 2009-09-17 23:28:31.000000000 +0200 +++ b/common/cmd_bdinfo.c 2009-09-21 20:10:45.000000000 +0200 @@ -31,7 +31,7 @@

static void print_num(const char *, ulong);

-#if !defined(CONFIG_ARM) || defined(CONFIG_CMD_NET) +#if !(defined(CONFIG_ARM) || defined(CONFIG_M68K)) || defined(CONFIG_CMD_NET) static void print_eth(int idx); #endif

@@ -349,7 +349,7 @@ printf ("%-12s= 0x%08lX\n", name, value); }

-#if !defined(CONFIG_ARM) || defined(CONFIG_CMD_NET) +#if !(defined(CONFIG_ARM) || defined(CONFIG_M68K)) || defined(CONFIG_CMD_NET) static void print_eth(int idx) { char name[10], *val;

Liew Tsi Chung-R5AAHP

22 Sep 22 Sep

8:31 p.m.

New subject: [U-Boot] [PATCH MAKEALL coldfire] : Fix start.S:Error: Conversionof PC relative displacement to absolute

Philippe,

The error that you encountered only happen when using linux cross compiler; however, if choosing uclinux cross compiler this will not be an issue.

Anyway, is an acked for me so that both compiler can be used without causing the problem.

Best Regards, TsiChung

-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Philippe De Muyter Sent: Monday, September 21, 2009 2:49 PM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH MAKEALL coldfire] : Fix start.S:Error: Conversionof PC relative displacement to absolute

Hi all,

This fixes the following errors when running MAKEALL for coldfire : start.S: Assembler messages: start.S:320: Error: Conversion of PC relative displacement to absolute

Signed-off-by: Philippe De Muyter phdm@macqel.be

_exc_handler: _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

5714

Age (days ago)

5715

Last active (days ago)

List overview

Download

7 comments

3 participants

tags (0)

participants (3)

Liew Tsi Chung-R5AAHP
Philippe De Muyter
Wolfgang Denk