i was going through the macaddr patchset to see if there was something else i missed and noticed that the changes to smc911x are missing a brace.

you'll probably want to squash this into the changeset: lan91c96/smc91111/smc911x: get mac address from environment -mike

--- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -437,7 +437,7 @@ static int smx911x_handle_mac_address(bd_t *bd) uchar m[6];

/* if the environment has a valid mac address then use it */ - if (!eth_getenv_enetaddr("ethaddr", m)) + if (!eth_getenv_enetaddr("ethaddr", m)) { /* if not, try to get one from the eeprom */ addrh = smc911x_get_mac_csr(ADDRH); addrl = smc911x_get_mac_csr(ADDRL);