On mar., oct. 17, 2023 at 20:57, "Guillaume La Roque" glaroque@baylibre.com wrote:

Patch which add A1 SoC support create a regression on khadas vim3/vim3l boards when we try to use fastboot command:

=> fastboot usb 0 failed to get power domain failed to get power domain No USB device found USB init failed: -19

Add ENOENT check on ret in probe function.

Fixes: 5533c883ce10 ("phy: support Amlogic A1 family")

Signed-off-by: Guillaume La Roque glaroque@baylibre.com

Tested on vim3 with:

=> fastboot usb 0

Tested-by: Mattijs Korpershoek mkorpershoek@baylibre.com # on vim3

---

drivers/phy/meson-g12a-usb2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/meson-g12a-usb2.c b/drivers/phy/meson-g12a-usb2.c index 4ba3992bda70..3958d2404b85 100644 --- a/drivers/phy/meson-g12a-usb2.c +++ b/drivers/phy/meson-g12a-usb2.c @@ -328,12 +328,12 @@ int meson_g12a_usb2_phy_probe(struct udevice *dev)

#if CONFIG_IS_ENABLED(POWER_DOMAIN) ret = power_domain_get(dev, &priv->pwrdm);

• if (ret < 0 && ret != -ENODEV) {

• pr_err("failed to get power domain\n");
  

• if (ret < 0 && ret != -ENODEV && ret != -ENOENT) {

• pr_err("failed to get power domain : %d\n", ret);
  

  return ret; }

• if (ret != -ENODEV) {

• if (ret != -ENODEV && ret != -ENOENT) { ret = power_domain_on(&priv->pwrdm); if (ret < 0) { pr_err("failed to enable power domain\n");

-- 2.34.1

-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#1773): https://groups.io/g/u-boot-amlogic/message/1773 Mute This Topic: https://groups.io/mt/102024645/1991006 Group Owner: u-boot-amlogic+owner@groups.io Unsubscribe: https://groups.io/g/u-boot-amlogic/unsub [mkorpershoek@baylibre.com] -=-=-=-=-=-=-=-=-=-=-=-