[PATCH 1/1] Makefile: don't use CFLAGS for environment text file
We use KCPPFLAGS to let the user set flags when invoking the C precompiler. These should also be used when generating the environment text file.
Reported-by: Dave Jones dave.jones@canonical.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index f0e6f07178f..4c469b9ce2b 100644 --- a/Makefile +++ b/Makefile @@ -1839,7 +1839,7 @@ ENV_FILE := $(if $(ENV_SOURCE_FILE),$(ENV_FILE_CFG),$(wildcard $(ENV_FILE_BOARD) quiet_cmd_gen_envp = ENVP $@ cmd_gen_envp = \ if [ -s "$(ENV_FILE)" ]; then \ - $(CPP) -P $(CFLAGS) -x assembler-with-cpp -undef \ + $(CPP) -P $(cpp_flags) -x assembler-with-cpp -undef \ -D__ASSEMBLY__ \ -D__UBOOT_CONFIG__ \ -I . -I include -I $(srctree)/include \
On Fri, 2 Aug 2024 at 07:50, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
We use KCPPFLAGS to let the user set flags when invoking the C precompiler. These should also be used when generating the environment text file.
Reported-by: Dave Jones dave.jones@canonical.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
diff --git a/Makefile b/Makefile index f0e6f07178f..4c469b9ce2b 100644 --- a/Makefile +++ b/Makefile @@ -1839,7 +1839,7 @@ ENV_FILE := $(if $(ENV_SOURCE_FILE),$(ENV_FILE_CFG),$(wildcard $(ENV_FILE_BOARD) quiet_cmd_gen_envp = ENVP $@ cmd_gen_envp = \ if [ -s "$(ENV_FILE)" ]; then \
$(CPP) -P $(CFLAGS) -x assembler-with-cpp -undef \
$(CPP) -P $(cpp_flags) -x assembler-with-cpp -undef \ -D__ASSEMBLY__ \ -D__UBOOT_CONFIG__ \ -I . -I include -I $(srctree)/include \-- 2.45.2
participants (2)
-
Heinrich Schuchardt -
Simon Glass