Re: [PATCH v3 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content
Hi Dmitry,
On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io" mkorpershoek=baylibre.com@groups.io wrote:
[...]
Reviewed-by: Simon Glass sjg@chromium.org
Can you also update the test?
I apologize, but I didn't quite understand your point. Could you please clarify? This patch series includes additional tests for the 'ab_dump' subcommand. For more details, please refer to:
https://lore.kernel.org/all/20241008-android_ab_master-v3-6-f292c45a33e4@sal...
OK, thank you. Sometimes it is easier (for reviewers) if you update the test in the same commit.
Should I resend the patch series with ab_dump implementation and tests in the same commit?
I can prepare new version, if needed, no problem.
No need to resend a new version just for this, since it's already been reviewed.
Keep the suggestion in mind for future series!
If you do need to re-spin this as v4, you can squash the test commit with this one if you wish.
-- Thank you, Dmitry
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#2438): https://groups.io/g/u-boot-amlogic/message/2438 Mute This Topic: https://groups.io/mt/108927502/1991006 Group Owner: u-boot-amlogic+owner@groups.io Unsubscribe: https://groups.io/g/u-boot-amlogic/unsub [mkorpershoek@baylibre.com] -=-=-=-=-=-=-=-=-=-=-=-
Hello Mattijs,
On Fri, Oct 11, 2024 at 04:22:43PM +0200, Mattijs Korpershoek wrote:
Hi Dmitry,
On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io" mkorpershoek=baylibre.com@groups.io wrote:
[...]
Reviewed-by: Simon Glass sjg@chromium.org
Can you also update the test?
I apologize, but I didn't quite understand your point. Could you please clarify? This patch series includes additional tests for the 'ab_dump' subcommand. For more details, please refer to:
https://lore.kernel.org/all/20241008-android_ab_master-v3-6-f292c45a33e4@sal...
OK, thank you. Sometimes it is easier (for reviewers) if you update the test in the same commit.
Should I resend the patch series with ab_dump implementation and tests in the same commit?
I can prepare new version, if needed, no problem.
No need to resend a new version just for this, since it's already been reviewed.
Keep the suggestion in mind for future series!
If you do need to re-spin this as v4, you can squash the test commit with this one if you wish.
Of course, I can re-spin that. I believe I can save all RvB trailers during the squashing process. Could you please clarify if my understanding is correct?
On ven., oct. 11, 2024 at 17:45, Dmitry Rokosov ddrokosov@salutedevices.com wrote:
Hello Mattijs,
On Fri, Oct 11, 2024 at 04:22:43PM +0200, Mattijs Korpershoek wrote:
Hi Dmitry,
On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io" mkorpershoek=baylibre.com@groups.io wrote:
[...]
> > Reviewed-by: Simon Glass sjg@chromium.org > > Can you also update the test?
I apologize, but I didn't quite understand your point. Could you please clarify? This patch series includes additional tests for the 'ab_dump' subcommand. For more details, please refer to:
https://lore.kernel.org/all/20241008-android_ab_master-v3-6-f292c45a33e4@sal...
OK, thank you. Sometimes it is easier (for reviewers) if you update the test in the same commit.
Should I resend the patch series with ab_dump implementation and tests in the same commit?
I can prepare new version, if needed, no problem.
No need to resend a new version just for this, since it's already been reviewed.
Keep the suggestion in mind for future series!
If you do need to re-spin this as v4, you can squash the test commit with this one if you wish.
Of course, I can re-spin that. I believe I can save all RvB trailers during the squashing process. Could you please clarify if my understanding is correct?
Yes, I believe your understanding is correct
-- Thank you, Dmitry
participants (2)
-
Dmitry Rokosov -
Mattijs Korpershoek