[PATCH] cmd/eeprom.c: prepend 0x to hex numbers in output message format
From: "Klaus H. Sorensen" khso@prevas.dk
If the numbers do not happen to contain any digits from [a-f], it's not clear that they are base 16.
Signed-off-by: Klaus H. Sorensen khso@prevas.dk Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk --- cmd/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/eeprom.c b/cmd/eeprom.c index 19953df082..23d9a21ab6 100644 --- a/cmd/eeprom.c +++ b/cmd/eeprom.c @@ -307,7 +307,7 @@ static int eeprom_execute_command(enum eeprom_action action, int i2c_bus, { int rcode = 0; const char *const fmt = - "\nEEPROM @0x%lX %s: addr %08lx off %04lx count %ld ... "; + "\nEEPROM @0x%lX %s: addr 0x%08lx off 0x%04lx count %ld ... "; #ifdef CONFIG_CMD_EEPROM_LAYOUT struct eeprom_layout layout; #endif
On Wed, 11 Dec 2019 11:18:29 +0000 Rasmus Villemoes rasmus.villemoes@prevas.dk wrote:
From: "Klaus H. Sorensen" khso@prevas.dk
If the numbers do not happen to contain any digits from [a-f], it's not clear that they are base 16.
Signed-off-by: Klaus H. Sorensen khso@prevas.dk Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk
cmd/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/eeprom.c b/cmd/eeprom.c index 19953df082..23d9a21ab6 100644 --- a/cmd/eeprom.c +++ b/cmd/eeprom.c @@ -307,7 +307,7 @@ static int eeprom_execute_command(enum eeprom_action action, int i2c_bus, { int rcode = 0; const char *const fmt =
"\nEEPROM @0x%lX %s: addr %08lx off %04lx count%ld ... ";
"\nEEPROM @0x%lX %s: addr 0x%08lx off 0x%04lxcount %ld ... "; #ifdef CONFIG_CMD_EEPROM_LAYOUT struct eeprom_layout layout; #endif
Reviewed-by: Lukasz Majewski lukma@denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hello Rasmus,
Am 11.12.2019 um 12:18 schrieb Rasmus Villemoes:
From: "Klaus H. Sorensen" khso@prevas.dk
If the numbers do not happen to contain any digits from [a-f], it's not clear that they are base 16.
Signed-off-by: Klaus H. Sorensen khso@prevas.dk Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk
cmd/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Heiko Schocher hs@denx.de
bye, Heiko
On Wed, Dec 11, 2019 at 11:18:29AM +0000, Rasmus Villemoes wrote:
From: "Klaus H. Sorensen" khso@prevas.dk
If the numbers do not happen to contain any digits from [a-f], it's not clear that they are base 16.
Signed-off-by: Klaus H. Sorensen khso@prevas.dk Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk Reviewed-by: Lukasz Majewski lukma@denx.de Reviewed-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
participants (4)
-
Heiko Schocher -
Lukasz Majewski -
Rasmus Villemoes -
Tom Rini