[PATCH 1/1] i2c: Bugfix in i2c_get_chip_by_phandle()
The "i2cbcdev" sneaked in when implementing this function for the bootcounter use case. Obviously the intention was to use prop_name instead.
Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle())
Signed-off-by: Philip Oberfichtner pro@denx.de --- drivers/i2c/i2c-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-uclass.c b/drivers/i2c/i2c-uclass.c index d0db25dcc0..3cbd4a81a5 100644 --- a/drivers/i2c/i2c-uclass.c +++ b/drivers/i2c/i2c-uclass.c @@ -428,7 +428,7 @@ int i2c_get_chip_by_phandle(const struct udevice *parent, const char *prop_name, goto err_exit; }
- ret = dev_read_u32(parent, "i2cbcdev", &phandle); + ret = dev_read_u32(parent, prop_name, &phandle); if (ret) goto err_exit;
Hello Philip,
On 24.11.23 15:04, Philip Oberfichtner wrote:
The "i2cbcdev" sneaked in when implementing this function for the bootcounter use case. Obviously the intention was to use prop_name instead.
Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle())
Signed-off-by: Philip Oberfichtner pro@denx.de
drivers/i2c/i2c-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Indeed!
Acked-by: Heiko Schocher hs@denx.de
@Tom: Do you want a pull request from me, or can you pick up this?
Thanks!
bye, Heiko
On Mon, Nov 27, 2023 at 07:12:35AM +0100, Heiko Schocher wrote:
Hello Philip,
On 24.11.23 15:04, Philip Oberfichtner wrote:
The "i2cbcdev" sneaked in when implementing this function for the bootcounter use case. Obviously the intention was to use prop_name instead.
Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle())
Signed-off-by: Philip Oberfichtner pro@denx.de
drivers/i2c/i2c-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Indeed!
Acked-by: Heiko Schocher hs@denx.de
@Tom: Do you want a pull request from me, or can you pick up this?
I can get just this, thanks.
On Fri, 24 Nov 2023 15:04:01 +0100, Philip Oberfichtner wrote:
The "i2cbcdev" sneaked in when implementing this function for the bootcounter use case. Obviously the intention was to use prop_name instead.
Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle())
[...]
Applied to u-boot/master, thanks!
participants (3)
-
Heiko Schocher -
Philip Oberfichtner -
Tom Rini