[U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable
From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001 From: Richard Retanubun RichardRetanubun@RuggedCom.com Date: Fri, 1 Oct 2010 10:17:26 -0400 Subject: [PATCH] board_init_r: Removed unused cmdtp variable
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp ---
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
- Richard
arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c index e6b81cc..96ccc7f 100644 --- a/arch/avr32/lib/board.c +++ b/arch/avr32/lib/board.c @@ -257,7 +257,6 @@ void board_init_r(gd_t *new_gd, ulong dest_addr) extern char * env_name_spec; #endif char *s; - cmd_tbl_t *cmdtp; bd_t *bd;
gd = new_gd; diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index acbdc58..3689ae3 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -405,7 +405,6 @@ board_init_f (ulong bootflag) */ void board_init_r (gd_t *id, ulong dest_addr) { - cmd_tbl_t *cmdtp; char *s; bd_t *bd; extern void malloc_bin_reloc (void); diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c index 2f259cb..cdc7824 100644 --- a/arch/mips/lib/board.c +++ b/arch/mips/lib/board.c @@ -284,7 +284,6 @@ void board_init_f(ulong bootflag)
void board_init_r (gd_t *id, ulong dest_addr) { - cmd_tbl_t *cmdtp; #ifndef CONFIG_SYS_NO_FLASH ulong size; #endif
Hello Richard,
Richard Retanubun wrote:
From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001 From: Richard Retanubun RichardRetanubun@RuggedCom.com Date: Fri, 1 Oct 2010 10:17:26 -0400 Subject: [PATCH] board_init_r: Removed unused cmdtp variable
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
Thanks, but already fixed in arch/arm/lib/board.c
bye, Heiko
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
Thanks, but already fixed in arch/arm/lib/board.c
bye, Heiko
Hi Heiko,
Does this mean I should cc the respective maintainers for avr32, m68k, and mips arch (the ones I found in my patch) to have them applied it? or was that a typo and you mean the patch is already applied on the ARM branch of the git repo?
Thanks,
- Richard
Hello Richard,
Richard Retanubun wrote:
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
Thanks, but already fixed in arch/arm/lib/board.c
bye, Heiko
Hi Heiko,
Does this mean I should cc the respective maintainers for avr32, m68k, and mips arch (the ones I found in my patch) to have them applied it?
Yes.
or was that a typo and you mean the patch is already applied on the ARM branch of the git repo?
I meant with "already fixed in arch/arm/lib/board.c", that in arch/arm/lib/board.c there is no such unused variable in code, so no need for fixing it there.
bye, Heiko
Dear Richard Retanubun,
In message 4CA5F6DC.90005@RuggedCom.com you wrote:
From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001 From: Richard Retanubun RichardRetanubun@RuggedCom.com Date: Fri, 1 Oct 2010 10:17:26 -0400 Subject: [PATCH] board_init_r: Removed unused cmdtp variable
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
Richard
arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
This patch does not apply (I think it is white-space corrupted):
Applying: board_init_r: Removed unused cmdtp variable Using index info to reconstruct a base tree... error: patch failed: arch/avr32/lib/board.c:257 error: arch/avr32/lib/board.c: patch does not apply error: patch failed: arch/m68k/lib/board.c:405 error: arch/m68k/lib/board.c: patch does not apply error: patch failed: arch/mips/lib/board.c:284 error: arch/mips/lib/board.c: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. Patch failed at 0001 board_init_r: Removed unused cmdtp variable
Please fix and resubmit.
Best regards,
Wolfgang Denk
Hi Wolfgang, sorry for the delay, here is the patch sent using git send-email.
From: Richard Retanubun RichardRetanubun@RuggedCom.com
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp --- arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c index e6b81cc..96ccc7f 100644 --- a/arch/avr32/lib/board.c +++ b/arch/avr32/lib/board.c @@ -257,7 +257,6 @@ void board_init_r(gd_t *new_gd, ulong dest_addr) extern char * env_name_spec; #endif char *s; - cmd_tbl_t *cmdtp; bd_t *bd;
gd = new_gd; diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index ae9478a..a8cb205 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -397,7 +397,6 @@ board_init_f (ulong bootflag) */ void board_init_r (gd_t *id, ulong dest_addr) { - cmd_tbl_t *cmdtp; char *s; bd_t *bd; extern void malloc_bin_reloc (void); diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c index 0044b19..4a22f7b 100644 --- a/arch/mips/lib/board.c +++ b/arch/mips/lib/board.c @@ -276,7 +276,6 @@ void board_init_f(ulong bootflag)
void board_init_r (gd_t *id, ulong dest_addr) { - cmd_tbl_t *cmdtp; #ifndef CONFIG_SYS_NO_FLASH ulong size; #endif
Dear Richard Retanubun,
In message 1287498595-23725-2-git-send-email-richardretanubun@ruggedcom.com you wrote:
From: Richard Retanubun RichardRetanubun@RuggedCom.com
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02 removed compiler warning for (now) unused cmd_tbl_t* cmdtp
arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (4)
-
Heiko Schocher -
Richard Retanubun -
Richard Retanubun
-
Wolfgang Denk