[PATCH 1/1] tools: mkefitools: remove duplicate test

This resolves Coverity CID 348360.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- tools/mkeficapsule.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c index f7590e482f..c118335b93 100644 --- a/tools/mkeficapsule.c +++ b/tools/mkeficapsule.c @@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx) cert.size = file_size;
ret = read_bin_file(ctx->key_file, &key.data, &file_size); - if (ret < 0) - return -1; if (ret < 0) return -1; if (file_size > UINT_MAX)

I have already fixed it.
https://lists.denx.de/pipermail/u-boot/2022-February/475391.html
-Takahiro Akashi
On Fri, Feb 18, 2022 at 09:26:33PM +0100, Heinrich Schuchardt wrote:
This resolves Coverity CID 348360.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
tools/mkeficapsule.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c index f7590e482f..c118335b93 100644 --- a/tools/mkeficapsule.c +++ b/tools/mkeficapsule.c @@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx) cert.size = file_size;
ret = read_bin_file(ctx->key_file, &key.data, &file_size);
- if (ret < 0)
if (ret < 0) return -1; if (file_size > UINT_MAX)return -1;
-- 2.34.1
participants (2)
-
AKASHI Takahiro
-
Heinrich Schuchardt