On 9/10/24 14:49, Sean Anderson wrote:

On 9/10/24 05:00, Jerome Forissier wrote:

...

Make SPL_RAM_SUPPORT a hidden Kconfig symbol, automatically selected by SPL_RAM_DEVICE or SPL_DFU. Avoids the situation where SPL_RAM_SUPPORT may be enabled without the other two being enabled, which results in the following build warning:

common/spl/spl_ram.c:19:14: warning: ‘spl_ram_load_read’ defined but not used [-Wunused-function]     19 | static ulong spl_ram_load_read(struct spl_load_info *load, ulong sector,        |              ^~~~~~~~~~~~~~~~~

Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

common/spl/Kconfig | 8 ++------   1 file changed, 2 insertions(+), 6 deletions(-)

Replaces "spl: ram: fix build warning when neither RAM_DEVICE nor DFU are enabled" [1].

[1] https://lists.denx.de/pipermail/u-boot/2024-September/564302.html

diff --git a/common/spl/Kconfig b/common/spl/Kconfig index c08ff064493..885a012461c 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -1238,15 +1238,11 @@ config SPL_POWER_DOMAIN         the drivers in drivers/power/domain as part of a SPL build.     config SPL_RAM_SUPPORT -    bool "Support booting from RAM" -    default y if MICROBLAZE || ARCH_SOCFPGA || ARCH_TEGRA || ARCH_ZYNQ -    help -      Enable booting of an image in RAM. The image can be preloaded or -      it can be loaded by SPL directly into RAM (e.g. using USB). +    bool     config SPL_RAM_DEVICE       bool "Support booting from preloaded image in RAM" -    depends on SPL_RAM_SUPPORT +    select SPL_RAM_SUPPORT       default y if MICROBLAZE || ARCH_SOCFPGA || ARCH_TEGRA || ARCH_ZYNQ       help         Enable booting of an image already loaded in RAM. The image has to

I think SPL_DFU should also select SPL_RAM_SUPPORT

Indeed, my mistake. v2 coming shortly.