[U-Boot] [PATCH] drivers: spi: Remove duplicate .probe method
From: Suniel Mahesh suniel.spartan@gmail.com
.probe method has been assigned twice when declaring a a driver with U_BOOT_DRIVER(). Removed one of them.
Signed-off-by: Suniel Mahesh suniel.spartan@gmail.com --- Note: Tested on latest u-boot mainline tree and maintainers u-boot-spi tree, no build issues. --- drivers/spi/omap3_spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/spi/omap3_spi.c b/drivers/spi/omap3_spi.c index 8a89450..76d376a 100644 --- a/drivers/spi/omap3_spi.c +++ b/drivers/spi/omap3_spi.c @@ -692,6 +692,5 @@ U_BOOT_DRIVER(omap3_spi) = { .probe = omap3_spi_probe, .ops = &omap3_spi_ops, .priv_auto_alloc_size = sizeof(struct omap3_spi_priv), - .probe = omap3_spi_probe, }; #endif
On Sat, Apr 29, 2017 at 12:32 AM, suniel.spartan@gmail.com wrote:
From: Suniel Mahesh suniel.spartan@gmail.com
.probe method has been assigned twice when declaring a a driver with U_BOOT_DRIVER(). Removed one of them.
Thanks,
Can you mark the details here like which commit has done this mistake?
"<commit_head_name>" (sha1: <commit_id>)
thanks!
On Tuesday 02 May 2017 04:19 PM, Jagan Teki wrote:
On Sat, Apr 29, 2017 at 12:32 AM, suniel.spartan@gmail.com wrote:
From: Suniel Mahesh suniel.spartan@gmail.com
.probe method has been assigned twice when declaring a a driver with U_BOOT_DRIVER(). Removed one of them.
Thanks,
Can you mark the details here like which commit has done this mistake?
"<commit_head_name>" (sha1: <commit_id>)
thanks!
I have gone through the log and mailing list, found that this commit might have made the mistake.
spi: omap3: Convert to driver model
sha1: 77b8d04854f486741471ad02b93b473b5b3d72f8
Thanks Jagan
On Tue, May 2, 2017 at 9:36 PM, Suniel Mahesh suniel.spartan@gmail.com wrote:
On Tuesday 02 May 2017 04:19 PM, Jagan Teki wrote:
On Sat, Apr 29, 2017 at 12:32 AM, suniel.spartan@gmail.com wrote:
From: Suniel Mahesh suniel.spartan@gmail.com
.probe method has been assigned twice when declaring a a driver with U_BOOT_DRIVER(). Removed one of them.
Thanks,
Can you mark the details here like which commit has done this mistake?
"<commit_head_name>" (sha1: <commit_id>)
thanks!
I have gone through the log and mailing list, found that this commit might have made the mistake.
spi: omap3: Convert to driver model
sha1: 77b8d04854f486741471ad02b93b473b5b3d72f8
Update these in commit message and send v2?
thanks!
From: Suniel Mahesh suniel.spartan@gmail.com
.probe method has been assigned twice when declaring a driver with U_BOOT_DRIVER(). Removed one of them. Here is the last commit which had the duplicate entry: "spi: omap3: Convert to driver model" (sha1: 77b8d04854f486741471ad02b93b473b5b3d72f8)
Signed-off-by: Suniel Mahesh suniel.spartan@gmail.com --- Note: Tested on latest u-boot mainline tree and maintainers u-boot-spi tree, no build issues. --- Changes for v2: Modified commit message to include details of the last commit which had the duplicate entry, as suggested by Jagan Teki --- drivers/spi/omap3_spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/spi/omap3_spi.c b/drivers/spi/omap3_spi.c index 8a89450..76d376a 100644 --- a/drivers/spi/omap3_spi.c +++ b/drivers/spi/omap3_spi.c @@ -692,6 +692,5 @@ U_BOOT_DRIVER(omap3_spi) = { .probe = omap3_spi_probe, .ops = &omap3_spi_ops, .priv_auto_alloc_size = sizeof(struct omap3_spi_priv), - .probe = omap3_spi_probe, }; #endif
On Wed, May 3, 2017 at 11:47 AM, suniel.spartan@gmail.com wrote:
From: Suniel Mahesh suniel.spartan@gmail.com
.probe method has been assigned twice when declaring a driver with U_BOOT_DRIVER(). Removed one of them. Here is the last commit which had the duplicate entry: "spi: omap3: Convert to driver model" (sha1: 77b8d04854f486741471ad02b93b473b5b3d72f8)
Applied to u-boot-spi/master
thanks!
participants (3)
-
Jagan Teki -
Suniel Mahesh -
suniel.spartan＠gmail.com