[U-Boot] [PATCH] malloc: Remove control-L in malloc.h
Remove what must've been a typo.
Signed-off-by: Marek Vasut marex@denx.de Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org --- include/malloc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h index 8175c75..e065473 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -215,7 +215,6 @@
*/
- #ifndef __MALLOC_H__ #define __MALLOC_H__
Marek Vasut marex@denx.de writes:
Remove what must've been a typo.
Signed-off-by: Marek Vasut marex@denx.de Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org
include/malloc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h index 8175c75..e065473 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -215,7 +215,6 @@
*/
- #ifndef __MALLOC_H__ #define __MALLOC_H__
--
It was probably intentional. I've seen ^L (form feed) occasionally in old code. Perhaps the author added it to make the file paginate better if printed on paper.
That said, I don't mind if you remove it.
Dear Marek,
In message 1464621732-7617-1-git-send-email-marex@denx.de you wrote:
Remove what must've been a typo.
Signed-off-by: Marek Vasut marex@denx.de Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org
include/malloc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h index 8175c75..e065473 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -215,7 +215,6 @@
*/
- #ifndef __MALLOC_H__ #define __MALLOC_H__
This is most likely NOT a typo, but an intentional page break (yes, there was a time when people used to _print_ source code on dead wood). And I bet if comes from the original imported dlmalloc code, so please check twice befoire introducing an unneeded difference.
Best regards,
Wolfgang Denk
On 05/30/2016 10:15 PM, Wolfgang Denk wrote:
Dear Marek,
In message 1464621732-7617-1-git-send-email-marex@denx.de you wrote:
Remove what must've been a typo.
Signed-off-by: Marek Vasut marex@denx.de Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org
include/malloc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h index 8175c75..e065473 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -215,7 +215,6 @@
*/
- #ifndef __MALLOC_H__ #define __MALLOC_H__
This is most likely NOT a typo, but an intentional page break (yes, there was a time when people used to _print_ source code on dead wood). And I bet if comes from the original imported dlmalloc code, so please check twice befoire introducing an unneeded difference.
Urgh, ok, feel free to drop this patch, I don't really care.
Best regards,
Wolfgang Denk
On 05/30/2016 10:37 PM, Marek Vasut wrote:
On 05/30/2016 10:15 PM, Wolfgang Denk wrote:
Dear Marek,
In message 1464621732-7617-1-git-send-email-marex@denx.de you wrote:
Remove what must've been a typo.
Signed-off-by: Marek Vasut marex@denx.de Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org
include/malloc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h index 8175c75..e065473 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -215,7 +215,6 @@
*/
- #ifndef __MALLOC_H__ #define __MALLOC_H__
This is most likely NOT a typo, but an intentional page break (yes, there was a time when people used to _print_ source code on dead wood). And I bet if comes from the original imported dlmalloc code, so please check twice befoire introducing an unneeded difference.
Urgh, ok, feel free to drop this patch, I don't really care.
...about this patch
I didn't expect to meet control-L in any files, that's new (old).
Marek Vasut marex@denx.de writes:
On 05/30/2016 10:37 PM, Marek Vasut wrote:
On 05/30/2016 10:15 PM, Wolfgang Denk wrote:
Dear Marek,
In message 1464621732-7617-1-git-send-email-marex@denx.de you wrote:
Remove what must've been a typo.
Signed-off-by: Marek Vasut marex@denx.de Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org
include/malloc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h index 8175c75..e065473 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -215,7 +215,6 @@
*/
- #ifndef __MALLOC_H__ #define __MALLOC_H__
This is most likely NOT a typo, but an intentional page break (yes, there was a time when people used to _print_ source code on dead wood). And I bet if comes from the original imported dlmalloc code, so please check twice befoire introducing an unneeded difference.
Urgh, ok, feel free to drop this patch, I don't really care.
...about this patch
I didn't expect to meet control-L in any files, that's new (old).
Kids these days...
Dear Måns,
In message yw1xvb1u4j5g.fsf@unicorn.mansr.com you wrote:
I didn't expect to meet control-L in any files, that's new (old).
Kids these days...
Right, never booted from a RK05 but complaining about code formatting :-)
Best regards,
Wolfgang Denk
participants (3)
-
Marek Vasut -
Måns Rullgård -
Wolfgang Denk