[U-Boot] [PATCH] tools: ifdtool: Do not write region while its size is negative
We should ignore those regions whose size is negative. These are typically optional and unused regions (like GbE and platform data).
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
tools/ifdtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/ifdtool.c b/tools/ifdtool.c index 590ccc9..1d61df1 100644 --- a/tools/ifdtool.c +++ b/tools/ifdtool.c @@ -462,7 +462,7 @@ static int write_regions(char *image, int size) if (ret) return ret; dump_region(i, frba); - if (region.size == 0) + if (region.size <= 0) continue; region_fd = open(region_filename(i), O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR |
On 31 May 2015 at 00:57, Bin Meng bmeng.cn@gmail.com wrote:
We should ignore those regions whose size is negative. These are typically optional and unused regions (like GbE and platform data).
Signed-off-by: Bin Meng bmeng.cn@gmail.com
tools/ifdtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
On 4 June 2015 at 03:03, Simon Glass sjg@chromium.org wrote:
On 31 May 2015 at 00:57, Bin Meng bmeng.cn@gmail.com wrote:
We should ignore those regions whose size is negative. These are typically optional and unused regions (like GbE and platform data).
Signed-off-by: Bin Meng bmeng.cn@gmail.com
tools/ifdtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86, thanks!
participants (2)
-
Bin Meng -
Simon Glass