[PATCH 1/2] imx: imx8mm_beacon: Remove redundant code
The function to return the default MMC device for the environment already has a __weak instance doing exactly the same thing. Remove the superfluous one.
Signed-off-by: Adam Ford aford173@gmail.com
diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c index 87ffebb571..c228bbf777 100644 --- a/board/beacon/imx8mm/imx8mm_beacon.c +++ b/board/beacon/imx8mm/imx8mm_beacon.c @@ -50,8 +50,3 @@ int board_init(void)
return 0; } - -int board_mmc_get_env_dev(int devno) -{ - return devno; -}
The function to return the default MMC device for the environment already has a __weak instance doing exactly the same thing. Remove the superfluous one.
Signed-off-by: Adam Ford aford173@gmail.com
diff --git a/board/beacon/imx8mn/imx8mn_beacon.c b/board/beacon/imx8mn/imx8mn_beacon.c index 7fe252b262..6397dac872 100644 --- a/board/beacon/imx8mn/imx8mn_beacon.c +++ b/board/beacon/imx8mn/imx8mn_beacon.c @@ -50,8 +50,3 @@ int board_init(void)
return 0; } - -int board_mmc_get_env_dev(int devno) -{ - return CONFIG_SYS_MMC_ENV_DEV; -}
The function to return the default MMC device for the environment already has a __weak instance doing exactly the same thing. Remove the superfluous one. Signed-off-by: Adam Ford aford173@gmail.com diff --git a/board/beacon/imx8mn/imx8mn_beacon.c b/board/beacon/imx8mn/imx8mn_beacon.c index 7fe252b262..6397dac872 100644 --- a/board/beacon/imx8mn/imx8mn_beacon.c +++ b/board/beacon/imx8mn/imx8mn_beacon.c @@ -50,8 +50,3 @@ int board_init(void)
return 0; }
-int board_mmc_get_env_dev(int devno) -{
- return CONFIG_SYS_MMC_ENV_DEV;
-}
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
The function to return the default MMC device for the environment already has a __weak instance doing exactly the same thing. Remove the superfluous one. Signed-off-by: Adam Ford aford173@gmail.com diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c index 87ffebb571..c228bbf777 100644 --- a/board/beacon/imx8mm/imx8mm_beacon.c +++ b/board/beacon/imx8mm/imx8mm_beacon.c @@ -50,8 +50,3 @@ int board_init(void)
return 0; }
-int board_mmc_get_env_dev(int devno) -{
- return devno;
-}
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (2)
-
Adam Ford -
sbabic＠denx.de