[U-Boot-Users] [patch] use unsigned char in smc91111 driver for mac
the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like: 0xFFFFFFE0 and that's no good -mike
In message 200704032049.25570.vapier@gentoo.org you wrote:
the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like: 0xFFFFFFE0 and that's no good
Dear Mike - good patch, but Signed-off-by: line is missing...
Best regards,
Wolfgang Denk
On Wednesday 04 April 2007, Wolfgang Denk wrote:
In message 200704032049.25570.vapier@gentoo.org you wrote:
the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like: 0xFFFFFFE0 and that's no good
Dear Mike - good patch, but Signed-off-by: line is missing...
Signed-off-by: Mike Frysinger vapier@gentoo.org -mike
On 4/4/07, Mike Frysinger vapier@gentoo.org wrote:
On Wednesday 04 April 2007, Wolfgang Denk wrote:
In message 200704032049.25570.vapier@gentoo.org you wrote:
the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like: 0xFFFFFFE0 and that's no good
Dear Mike - good patch, but Signed-off-by: line is missing...
Signed-off-by: Mike Frysinger vapier@gentoo.org -mike
Just want to know the status of this patch, thanks.
Best Regards, -Aubrey
participants (3)
-
Aubrey Li -
Mike Frysinger -
Wolfgang Denk