[U-Boot] [PATCH] TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup
The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.
Signed-off-by: Becky Bruce beckyb@kernel.crashing.org --- This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.
board/tqc/tqm85xx/tqm85xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/tqc/tqm85xx/tqm85xx.c b/board/tqc/tqm85xx/tqm85xx.c index 2c3885f..b21e791 100644 --- a/board/tqc/tqm85xx/tqm85xx.c +++ b/board/tqc/tqm85xx/tqm85xx.c @@ -298,7 +298,7 @@ int misc_init_r (void) */ set_lbc_or(0, ((-flash_info[1].size) & 0xffff8000) | (CONFIG_SYS_OR0_PRELIM & 0x00007fff)); - set_lbc_br(0, gd->bd->bi_flashstart | + set_lbc_br(0, (gd->bd->bi_flashstart + flash_info[0].size) | (CONFIG_SYS_BR0_PRELIM & 0x00007fff));
/*
Dear Becky Bruce,
In message 1289496785-9243-1-git-send-email-beckyb@kernel.crashing.org you wrote:
The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.
Signed-off-by: Becky Bruce beckyb@kernel.crashing.org
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.
It build just fine for me... What exactly are your problems? [And which tool chain are you using?]
Your patch indeed fixes the problem (and I'm a bit angry with myself that I didn't see this problem myself.)
Thanks a lot!
Tested on TQM8555.
Tested-by: Wolfgang Denk wd@denx.de Acked-by: Wolfgang Denk wd@denx.de
Best regards,
Wolfgang Denk
On Nov 11, 2010, at 4:30 PM, Wolfgang Denk wrote:
Dear Becky Bruce,
In message 1289496785-9243-1-git-send-email-beckyb@kernel.crashing.org you wrote:
The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.
Signed-off-by: Becky Bruce beckyb@kernel.crashing.org
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.
It build just fine for me... What exactly are your problems? [And which tool chain are you using?]
Actually, that looks to be spurious - I thought i was building from a clean tree but turns out it wasn't. When I do a clean and then a build it works fine. This is what happens when you write code from your car.....
Your patch indeed fixes the problem (and I'm a bit angry with myself that I didn't see this problem myself.)
Well, that's two of us, because I'm a bit angry at myself for causing it :)
Cheers, B
Thanks a lot!
Tested on TQM8555.
Tested-by: Wolfgang Denk wd@denx.de Acked-by: Wolfgang Denk wd@denx.de
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de We are all agreed that your theory is crazy. The question which divides us is whether it is crazy enough to have a chance of being correct. My own feeling is that it is not crazy enough. - Niels Bohr
On Nov 11, 2010, at 11:33 AM, Becky Bruce wrote:
The size of the other bank needed to be added to the br0 setting; this got dropped in the LBC cleanup.
Signed-off-by: Becky Bruce beckyb@kernel.crashing.org
This has been neither built or tested, as TQM8555 doesn't seem to build on the head of this tree, and I don't have a board to test on.
board/tqc/tqm85xx/tqm85xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied to 85xx
- k
participants (3)
-
Becky Bruce -
Kumar Gala -
Wolfgang Denk