Dear Adam,

in message EFB813091B18D511BD3600508B644F8214DC7698@tx14exm06.ftw.mot.com you wrote:

The attached patch adds compact flash @ TI PCI1510 support for the MPC8540ADS reference platform. I've tested the patch with the following CF cards:

• SanDisk 512MB commercial grade
• SanDisk 512MB standard grade
• SiliconSystems 512MB SiliconDriveCF
• SimpleTech 512MB & 1GB J series

The MPC8540ADS platform contained the following PCI cards:

• TI PCI1510 EVM card
• Intel GD82559 Ethernet card

I'm afraid I have to reject your patch.

First some formal reasons:

* CHANGELOG entry missing * Coding Style violations (trailing white space, wrong indentation, etc.) * You add a cople of new config options (like CONFIG_IDE_CARDBUS_CF_16BIT) without any documentation.

Technical reasons:

I think your changes to drivers/ti_pci1410a.c might have impact on (read: will break) existing board support that uses this driver. Did you check this with the previous authors?

You change the default configuration of the MPC8540ADS board; did you check this with the maintainer of this board?

Best regards,

Wolfgang Denk