[U-Boot] [GIT PULL] Please pull u-boot-mmc master
Dear Tom,
Could you pull these patches to u-boot/master? Main topic is the support for HS200/UHS mode. If there are any problem, let me know. After applying to u-boot/master, will apply the other patches.
The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
Prepare v2018.01 (2018-01-08 20:25:29 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-mmc.git master
for you to fetch changes up to db359efd5907edbeaea2e3eb3504729f60208cd8:
mmc: fsl_esdhc: Fix eMMC 1.8v setting issue (2018-01-13 00:08:44 +0900)
---------------------------------------------------------------- Felix Brack (1): mmc: sanitize includes for DM i2c
Heinrich Schuchardt (1): mmc: sdhci: do not compare pointer to 0
Jaehoon Chung (1): mmc: meson_gx_mmc: fix the complie error
Jean-Jacques Hiblot (38): mmc: dm: get the IO-line and main voltage regulators from the dts mmc: split mmc_startup() mmc: move the MMC startup for version above v4.0 in a separate function mmc: make ext_csd part of struct mmc mmc: add a function to read and test the ext csd (mmc >= 4) mmc: introduce mmc modes mmc: Add a function to dump the mmc capabilities mmc: use mmc modes to select the correct bus speed cmd: mmc: display the mode name and current bus speed in the mmc info mmc: refactor SD startup to make it easier to support new modes mmc: refactor MMC startup to make it easier to support new modes mmc: Add a new callback function to perform the 74 clocks cycle sequence mmc: Add support for UHS modes mmc: disable UHS modes if Vcc cannot be switched on and off mmc: Change mode when switching to a boot partition mmc: use the right voltage level for MMC DDR and HS200 modes mmc: add a library function to send tuning command mmc: dump card and host capabilities if debug is enabled dm: mmc: update mmc_of_parse() mmc: Fixed a problem with old sd or mmc that do not support High speed mmc: all hosts support 1-bit bus width and legacy timings mmc: fix for old MMCs (below version 4) mmc: don't use malloc_cache_aligned() mmc: convert most of printf() to pr_err() and pr_warn() mmc: make UHS and HS200 optional mmc: make optional the support for eMMC hardware partitioning configs: openrd: removed support for eMMC hardware partitioning configs: omapl138_lcdk: decrease the loglevel to reduce the size of the SPL dm: mmc: sandbox: Update SD card emulation common: do not compile common fastboot code when building the SPL mmc: atmel: when sending a data command, use the provided block size mmc: compile out more code if support for UHS and HS200 is not enabled mmc: reworked version lookup in mmc_startup_v4 mmc: add a Kconfig option to enable the support for MMC write operations mmc: read ssr only if MMC write support is enabled mmc: compile out erase and write mmc commands if write operations are not enabled mmc: don't read the size of eMMC enhanced user data area in SPL mmc: remove hc_wp_grp_size from struct mmc if not needed
Jorge Ramirez-Ortiz (1): mmc: sdhci: don't clear SDHCI_INT_STATUS register during CMD_INHIBIT
Kishon Vijay Abraham I (9): mmc: make mmc_set_ios() return status mmc: Enable signal voltage to be selected from mmc core mmc: add power cyle support in mmc core mmc: add a new mmc parameter to disable mmc clock mmc: disable the mmc clock during power off mmc: Add a execute_tuning() callback to the mmc operations. mmc: add HS200 support in MMC core mmc: Retry some MMC cmds on failure dm: mmc: Add a library function to parse generic dt binding
Peng Fan (1): mmc: fsl_esdhc: Fix eMMC 1.8v setting issue
Suniel Mahesh (2): drivers: mmc: Change buffer type in ALLOC_CACHE_ALIGN_BUFFER macro drivers: mmc: Avoid memory leak in case of failure
Tom Rini (2): am335x_hs_evm: Trim options in SPL to reduce binary size power: Rearrange code to guard power command with CONFIG_SPL_BUILD guard
cmd/mmc.c | 21 +- cmd/mvebu/bubt.c | 2 +- common/Makefile | 2 + common/spl/Kconfig | 9 + configs/am335x_hs_evm_defconfig | 4 + configs/omapl138_lcdk_defconfig | 1 + configs/openrd_base_defconfig | 1 + configs/openrd_client_defconfig | 1 + configs/openrd_ultimate_defconfig | 1 + drivers/mmc/Kconfig | 76 ++ drivers/mmc/Makefile | 4 +- drivers/mmc/exynos_dw_mmc.c | 3 + drivers/mmc/fsl_esdhc.c | 11 +- drivers/mmc/gen_atmel_mci.c | 42 +- drivers/mmc/meson_gx_mmc.c | 2 +- drivers/mmc/mmc-uclass.c | 99 ++- drivers/mmc/mmc.c | 1642 ++++++++++++++++++++++++++++--------- drivers/mmc/mmc_private.h | 4 +- drivers/mmc/omap_hsmmc.c | 4 +- drivers/mmc/sandbox_mmc.c | 5 +- drivers/mmc/sdhci.c | 7 +- drivers/power/power_core.c | 61 +- include/mmc.h | 212 ++++- 23 files changed, 1745 insertions(+), 469 deletions(-)
Best Regards, Jaehoon Chung
On Mon, Jan 15, 2018 at 11:35:05AM +0900, Jaehoon Chung wrote:
Dear Tom,
Could you pull these patches to u-boot/master? Main topic is the support for HS200/UHS mode. If there are any problem, let me know. After applying to u-boot/master, will apply the other patches.
The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
Prepare v2018.01 (2018-01-08 20:25:29 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-mmc.git master
for you to fetch changes up to db359efd5907edbeaea2e3eb3504729f60208cd8:
mmc: fsl_esdhc: Fix eMMC 1.8v setting issue (2018-01-13 00:08:44 +0900)
Applied to u-boot/master, thanks!
But please note the following issues from checkpatch that need to be looked into and possibly followed up on: CHECK: Macro argument reuse 'mwt' - possible side-effects? #180: FILE: drivers/mmc/mmc.c:1245: +#define for_each_sd_mode_by_pref(caps, mwt) \ + for (mwt = sd_modes_by_pref;\ + mwt < sd_modes_by_pref + ARRAY_SIZE(sd_modes_by_pref);\ + mwt++) \ + if (caps & MMC_CAP(mwt->mode))
total: 0 errors, 0 warnings, 1 checks, 265 lines checked CHECK: Macro argument reuse 'mwt' - possible side-effects? #159: FILE: drivers/mmc/mmc.c:1382: +#define for_each_mmc_mode_by_pref(caps, mwt) \ + for (mwt = mmc_modes_by_pref;\ + mwt < mmc_modes_by_pref + ARRAY_SIZE(mmc_modes_by_pref);\ + mwt++) \ + if (caps & MMC_CAP(mwt->mode))
CHECK: Macro argument reuse 'ecbv' - possible side-effects? #177: FILE: drivers/mmc/mmc.c:1400: +#define for_each_supported_width(caps, ddr, ecbv) \ + for (ecbv = ext_csd_bus_width;\ + ecbv < ext_csd_bus_width + ARRAY_SIZE(ext_csd_bus_width);\ + ecbv++) \ + if ((ddr == ecbv->is_ddr) && (caps & ecbv->cap))
CHECK: Alignment should match open parenthesis #253: FILE: drivers/mmc/mmc.c:1437: + err = mmc_switch(mmc, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_BUS_WIDTH,
WARNING: 'occured' may be misspelled - perhaps 'occurred'? #292: FILE: drivers/mmc/mmc.c:1469: + /* if an error occured, revert to a safer bus mode */
total: 0 errors, 1 warnings, 3 checks, 320 lines checked WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: function ignore this. Modify mmc_set_ios() and the callers of mmc_set_ios() to
total: 0 errors, 1 warnings, 0 checks, 46 lines checked WARNING: ENOSYS means 'invalid syscall nr' and nothing else #30: FILE: drivers/mmc/mmc-uclass.c:100: + return -ENOSYS;
total: 0 errors, 1 warnings, 0 checks, 60 lines checked WARNING: 'capabilites' may be misspelled - perhaps 'capabilities'? #6: Add UHS modes to the list of supported modes, get the UHS capabilites of
total: 0 errors, 5 warnings, 0 checks, 381 lines checked WARNING: line over 80 characters #59: FILE: drivers/mmc/mmc.c:2217: + debug("Unable to do a full power cycle. Disabling the UHS modes for safety\n");
total: 0 errors, 1 warnings, 0 checks, 50 lines checked WARNING: 'optionnal' may be misspelled - perhaps 'optional'? #13: To make it clear that those are optionnal workarounds, a new Kconfig
total: 0 errors, 1 warnings, 0 checks, 102 lines checked WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #6: The SDcard initialization procedure does a few more things than it did earlier:
total: 0 errors, 1 warnings, 0 checks, 13 lines checked WARNING: please write a paragraph that describes the config symbol fully #50: FILE: common/spl/Kconfig:419: +config SPL_MMC_WRITE
WARNING: please write a paragraph that describes the config symbol fully #69: FILE: drivers/mmc/Kconfig:13: +config MMC_WRITE
total: 0 errors, 2 warnings, 0 checks, 82 lines checked CHECK: Unbalanced braces around else statement #85: FILE: drivers/mmc/mmc.c:2089: + else {
total: 0 errors, 0 warnings, 1 checks, 116 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 403 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644
On 01/15/2018 10:53 PM, Tom Rini wrote:
On Mon, Jan 15, 2018 at 11:35:05AM +0900, Jaehoon Chung wrote:
Dear Tom,
Could you pull these patches to u-boot/master? Main topic is the support for HS200/UHS mode. If there are any problem, let me know. After applying to u-boot/master, will apply the other patches.
The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
Prepare v2018.01 (2018-01-08 20:25:29 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-mmc.git master
for you to fetch changes up to db359efd5907edbeaea2e3eb3504729f60208cd8:
mmc: fsl_esdhc: Fix eMMC 1.8v setting issue (2018-01-13 00:08:44 +0900)
Applied to u-boot/master, thanks!
Thanks!
But please note the following issues from checkpatch that need to be looked into and possibly followed up on:
I have also checked from checkpatch.pl..Will fix the something to check.
Best Regards, Jaehoon Chung
CHECK: Macro argument reuse 'mwt' - possible side-effects? #180: FILE: drivers/mmc/mmc.c:1245: +#define for_each_sd_mode_by_pref(caps, mwt) \
- for (mwt = sd_modes_by_pref;\
mwt < sd_modes_by_pref + ARRAY_SIZE(sd_modes_by_pref);\mwt++) \if (caps & MMC_CAP(mwt->mode))total: 0 errors, 0 warnings, 1 checks, 265 lines checked CHECK: Macro argument reuse 'mwt' - possible side-effects? #159: FILE: drivers/mmc/mmc.c:1382: +#define for_each_mmc_mode_by_pref(caps, mwt) \
- for (mwt = mmc_modes_by_pref;\
mwt < mmc_modes_by_pref + ARRAY_SIZE(mmc_modes_by_pref);\mwt++) \if (caps & MMC_CAP(mwt->mode))CHECK: Macro argument reuse 'ecbv' - possible side-effects? #177: FILE: drivers/mmc/mmc.c:1400: +#define for_each_supported_width(caps, ddr, ecbv) \
- for (ecbv = ext_csd_bus_width;\
ecbv < ext_csd_bus_width + ARRAY_SIZE(ext_csd_bus_width);\ecbv++) \if ((ddr == ecbv->is_ddr) && (caps & ecbv->cap))CHECK: Alignment should match open parenthesis #253: FILE: drivers/mmc/mmc.c:1437:
err = mmc_switch(mmc, EXT_CSD_CMD_SET_NORMAL,EXT_CSD_BUS_WIDTH,WARNING: 'occured' may be misspelled - perhaps 'occurred'? #292: FILE: drivers/mmc/mmc.c:1469:
/* if an error occured, revert to a safer bus mode */total: 0 errors, 1 warnings, 3 checks, 320 lines checked WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: function ignore this. Modify mmc_set_ios() and the callers of mmc_set_ios() to
total: 0 errors, 1 warnings, 0 checks, 46 lines checked WARNING: ENOSYS means 'invalid syscall nr' and nothing else #30: FILE: drivers/mmc/mmc-uclass.c:100:
return -ENOSYS;total: 0 errors, 1 warnings, 0 checks, 60 lines checked WARNING: 'capabilites' may be misspelled - perhaps 'capabilities'? #6: Add UHS modes to the list of supported modes, get the UHS capabilites of
total: 0 errors, 5 warnings, 0 checks, 381 lines checked WARNING: line over 80 characters #59: FILE: drivers/mmc/mmc.c:2217:
debug("Unable to do a full power cycle. Disabling the UHS modes for safety\n");total: 0 errors, 1 warnings, 0 checks, 50 lines checked WARNING: 'optionnal' may be misspelled - perhaps 'optional'? #13: To make it clear that those are optionnal workarounds, a new Kconfig
total: 0 errors, 1 warnings, 0 checks, 102 lines checked WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #6: The SDcard initialization procedure does a few more things than it did earlier:
total: 0 errors, 1 warnings, 0 checks, 13 lines checked WARNING: please write a paragraph that describes the config symbol fully #50: FILE: common/spl/Kconfig:419: +config SPL_MMC_WRITE
WARNING: please write a paragraph that describes the config symbol fully #69: FILE: drivers/mmc/Kconfig:13: +config MMC_WRITE
total: 0 errors, 2 warnings, 0 checks, 82 lines checked CHECK: Unbalanced braces around else statement #85: FILE: drivers/mmc/mmc.c:2089:
- else {
total: 0 errors, 0 warnings, 1 checks, 116 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 403 lines checked WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644
participants (2)
-
Jaehoon Chung -
Tom Rini