[U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu

Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig index 0cea3694d0..4ebf062156 100644 --- a/configs/qemu-x86_64_defconfig +++ b/configs/qemu-x86_64_defconfig @@ -14,6 +14,7 @@ CONFIG_SMP=y CONFIG_GENERATE_PIRQ_TABLE=y CONFIG_GENERATE_MP_TABLE=y CONFIG_GENERATE_ACPI_TABLE=y +CONFIG_DISTRO_DEFAULTS=y CONFIG_BUILD_ROM=y CONFIG_FIT=y CONFIG_SPL_LOAD_FIT=y diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig index bf7fbc723d..5dfc8307b3 100644 --- a/configs/qemu-x86_defconfig +++ b/configs/qemu-x86_defconfig @@ -5,6 +5,7 @@ CONFIG_SMP=y CONFIG_GENERATE_PIRQ_TABLE=y CONFIG_GENERATE_MP_TABLE=y CONFIG_GENERATE_ACPI_TABLE=y +CONFIG_DISTRO_DEFAULTS=y CONFIG_BUILD_ROM=y CONFIG_FIT=y CONFIG_BOOTSTAGE=y

On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com

On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!

Hi Heinrich,
On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
Unfortunately, this creates build warnings on QEMU.
include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined #define CONFIG_BOOTCOMMAND \ ^
Can you please post your new patch against u-boot-x86/master that fixes this issue?
Regards, Bin

Hi Heinrich,
On Fri, Nov 24, 2017 at 4:12 PM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Heinrich,
On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
Unfortunately, this creates build warnings on QEMU.
include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined #define CONFIG_BOOTCOMMAND \ ^
Can you please post your new patch against u-boot-x86/master that fixes this issue?
Did you get a chance to look at this?
Regards, Bin

On 11/29/2017 10:00 AM, Bin Meng wrote:
Hi Heinrich,
On Fri, Nov 24, 2017 at 4:12 PM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Heinrich,
On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
Unfortunately, this creates build warnings on QEMU.
include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined #define CONFIG_BOOTCOMMAND \ ^
Can you please post your new patch against u-boot-x86/master that fixes this issue?
Did you get a chance to look at this?
Regards, Bin
Hello Bin,
there seem quite a lot of changes needed to get DISTRO_DEFAUlTS running on x86. It's not only the double definition.
Please, remove the patch from your queue.
Best regards
Heinrich

Hi Heinrich,
On Thu, Nov 30, 2017 at 2:46 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 11/29/2017 10:00 AM, Bin Meng wrote:
Hi Heinrich,
On Fri, Nov 24, 2017 at 4:12 PM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Heinrich,
On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/qemu-x86_64_defconfig | 1 + configs/qemu-x86_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
Unfortunately, this creates build warnings on QEMU.
include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined #define CONFIG_BOOTCOMMAND \ ^
Can you please post your new patch against u-boot-x86/master that fixes this issue?
Did you get a chance to look at this?
Regards, Bin
Hello Bin,
there seem quite a lot of changes needed to get DISTRO_DEFAUlTS running on x86. It's not only the double definition.
Please, remove the patch from your queue.
Thanks for your confirmation.
Regards, Bin
participants (2)
-
Bin Meng
-
Heinrich Schuchardt