[U-Boot] [PATCH 1/2] ARM: tegra: make bounce buffer option
From: Stephen Warren swarren@nvidia.com
All Tegra devices will need CONFIG_BOUNCE_BUFFER. Move it to tegra-common.h to ensure it's always set.
Signed-off-by: Stephen Warren swarren@nvidia.com --- These are useful on top of Tom's Tegra30 MMC series.
include/configs/tegra-common.h | 3 +++ include/configs/tegra20-common.h | 3 --- include/configs/tegra30-common.h | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index 4a656bb..a3cb5b9 100644 --- a/include/configs/tegra-common.h +++ b/include/configs/tegra-common.h @@ -157,4 +157,7 @@ #define CONFIG_SPL_SERIAL_SUPPORT #define CONFIG_SPL_GPIO_SUPPORT
+/* Misc utility code */ +#define CONFIG_BOUNCE_BUFFER + #endif /* _TEGRA_COMMON_H_ */ diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h index 186e023..c51de00 100644 --- a/include/configs/tegra20-common.h +++ b/include/configs/tegra20-common.h @@ -120,7 +120,4 @@ #define CONFIG_SYS_NAND_SELF_INIT #define CONFIG_SYS_NAND_ONFI_DETECTION
-/* Misc utility code */ -#define CONFIG_BOUNCE_BUFFER - #endif /* _TEGRA20_COMMON_H_ */ diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h index 82b1c07..f6c07c6 100644 --- a/include/configs/tegra30-common.h +++ b/include/configs/tegra30-common.h @@ -92,7 +92,4 @@ /* Total I2C ports on Tegra30 */ #define TEGRA_I2C_NUM_CONTROLLERS 5
-/* Misc utility code */ -#define CONFIG_BOUNCE_BUFFER - #endif /* _TEGRA30_COMMON_H_ */
From: Stephen Warren swarren@nvidia.com
This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.
Signed-off-by: Stephen Warren swarren@nvidia.com --- include/configs/tegra-common.h | 2 ++ include/configs/tegra20-common.h | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index a3cb5b9..45f0099 100644 --- a/include/configs/tegra-common.h +++ b/include/configs/tegra-common.h @@ -141,6 +141,8 @@ #define CONFIG_CMD_GPIO #define CONFIG_CMD_ENTERRCM #define CONFIG_CMD_BOOTZ +#define CONFIG_PARTITION_UUIDS +#define CONFIG_CMD_PART
/* Defines for SPL */ #define CONFIG_SPL diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h index c51de00..e464e06 100644 --- a/include/configs/tegra20-common.h +++ b/include/configs/tegra20-common.h @@ -114,9 +114,6 @@ /* Total I2C ports on Tegra20 */ #define TEGRA_I2C_NUM_CONTROLLERS 4
-#define CONFIG_PARTITION_UUIDS -#define CONFIG_CMD_PART - #define CONFIG_SYS_NAND_SELF_INIT #define CONFIG_SYS_NAND_ONFI_DETECTION
On 02/26/2013 04:00 PM, Stephen Warren wrote:
This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.
Unfortunately, this breaks Tegra114 builds because no partition types are enabled, and CONFIG_CMD_PART requires functionality that's only enabled if some partition types are supported.
There are two possible solutions:
1) Conditionally enable PARTITION_UUIDS and CMD_PART in tegra-common-post.h only if some partition type is enabled.
2) Also enable DOS and EFI partitions in tegra-common.h, along with all of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards this won't be any change. For the Colibri T20 and Avionic Design boards, this ends up enabling a few more options.
(or perhaps enable all of those in tegra-common-post.h only if support for any block device is enabled)
I prefer option (2). Does anyone object?
On Wed, Feb 27, 2013 at 02:03:37PM -0700, Stephen Warren wrote:
On 02/26/2013 04:00 PM, Stephen Warren wrote:
This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.
Unfortunately, this breaks Tegra114 builds because no partition types are enabled, and CONFIG_CMD_PART requires functionality that's only enabled if some partition types are supported.
There are two possible solutions:
- Conditionally enable PARTITION_UUIDS and CMD_PART in
tegra-common-post.h only if some partition type is enabled.
- Also enable DOS and EFI partitions in tegra-common.h, along with all
of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards this won't be any change. For the Colibri T20 and Avionic Design boards, this ends up enabling a few more options.
(or perhaps enable all of those in tegra-common-post.h only if support for any block device is enabled)
I prefer option (2). Does anyone object?
Fine with me. I recently posted patches that enable some of these options as part of boot script support on Tamonten boards anyway.
Thierry
Am Mittwoch, den 27.02.2013, 14:03 -0700 schrieb Stephen Warren:
On 02/26/2013 04:00 PM, Stephen Warren wrote:
This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.
Unfortunately, this breaks Tegra114 builds because no partition types are enabled, and CONFIG_CMD_PART requires functionality that's only enabled if some partition types are supported.
There are two possible solutions:
- Conditionally enable PARTITION_UUIDS and CMD_PART in
tegra-common-post.h only if some partition type is enabled.
- Also enable DOS and EFI partitions in tegra-common.h, along with all
of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards this won't be any change. For the Colibri T20 and Avionic Design boards, this ends up enabling a few more options.
(or perhaps enable all of those in tegra-common-post.h only if support for any block device is enabled)
I prefer option (2). Does anyone object?
No objections. There is no real reason to leave out all those options as we are not size limited on the Colibri.
Regards, Lucas
participants (3)
-
Lucas Stach -
Stephen Warren -
Thierry Reding