On 4 July 2015 at 18:23, R, Vignesh vigneshr@ti.com wrote:

On 7/3/2015 7:27 PM, Andy Pont wrote:

...

Vignesh wrote...

[snip]

...

+#define BIT(x) (1 << (x))

Is this not something that would be better in a global header file somewhere rather than it starting a trend of a per-driver, per-arch, etc. definitions?

I agree there are few per arch defintions. How about adding it to include/linux/bitops.h as in linux kernel?

Patch is under review [1] in fact you may give comment on the same.

[1] https://patchwork.ozlabs.org/patch/470478/

thanks!