[U-Boot] [PATCH] rockchip: clk: rk3288: handle clk_enable requests for GMAC

Since b0ba1e7e9d9b9441a18048ec67a3b3100c096975 (rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC) Ethernet no longer probes on RK3288.
Add no-ops for GMAC clocks observed to be requested which match the clk_enable cases in RK3368 and RK3399.
Signed-off-by: Jonathan Gray jsg@jsg.id.au Cc: Wadim Egorov w.egorov@phytec.de Cc: Philipp Tomsich philipp.tomsich@theobroma-systems.com --- drivers/clk/rockchip/clk_rk3288.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/drivers/clk/rockchip/clk_rk3288.c b/drivers/clk/rockchip/clk_rk3288.c index 9375681187..4a6e5c7113 100644 --- a/drivers/clk/rockchip/clk_rk3288.c +++ b/drivers/clk/rockchip/clk_rk3288.c @@ -898,6 +898,16 @@ static int rk3288_clk_enable(struct clk *clk) case HCLK_USBHOST0: case HCLK_HSIC: return 0; + + case SCLK_MAC: + case SCLK_MAC_RX: + case SCLK_MAC_TX: + case SCLK_MACREF: + case SCLK_MACREF_OUT: + case ACLK_GMAC: + case PCLK_GMAC: + /* Required to successfully probe the Designware GMAC driver */ + return 0; }
debug("%s: unsupported clk %ld\n", __func__, clk->id);

On 8 May 2018, at 11:49, Jonathan Gray jsg@jsg.id.au wrote:
Since b0ba1e7e9d9b9441a18048ec67a3b3100c096975 (rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC) Ethernet no longer probes on RK3288.
Add no-ops for GMAC clocks observed to be requested which match the clk_enable cases in RK3368 and RK3399.
Signed-off-by: Jonathan Gray jsg@jsg.id.au Cc: Wadim Egorov w.egorov@phytec.de Cc: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Thanks for the quick turnaround. I’ll give this a day or two, for others to also review/test and will then merge from the front of the queue.
Acked-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com

Since b0ba1e7e9d9b9441a18048ec67a3b3100c096975 (rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC) Ethernet no longer probes on RK3288.
Add no-ops for GMAC clocks observed to be requested which match the clk_enable cases in RK3368 and RK3399.
Signed-off-by: Jonathan Gray jsg@jsg.id.au Cc: Wadim Egorov w.egorov@phytec.de Cc: Philipp Tomsich philipp.tomsich@theobroma-systems.com Acked-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
drivers/clk/rockchip/clk_rk3288.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
Applied to u-boot-rockchip, thanks!
participants (3)
-
Dr. Philipp Tomsich
-
Jonathan Gray
-
Philipp Tomsich