[PATCH] board: ea: mx7ulp_com: allocate specific region of memory to OP-TEE
From: Ricardo Salveti ricardo@foundries.io
On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid conflicts.
Note the OPTEE boot process itself subtracts the DRAM region it lives in from the memory map passed to Linux.
Signed-off-by: Ricardo Salveti ricardo@foundries.io ---
board/ea/mx7ulp_com/mx7ulp_com.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/board/ea/mx7ulp_com/mx7ulp_com.c b/board/ea/mx7ulp_com/mx7ulp_com.c index 5b2d444366..7fce75ade9 100644 --- a/board/ea/mx7ulp_com/mx7ulp_com.c +++ b/board/ea/mx7ulp_com/mx7ulp_com.c @@ -20,6 +20,10 @@ int dram_init(void) { gd->ram_size = imx_ddr_size();
+#ifdef CONFIG_OPTEE_TZDRAM_SIZE + gd->ram_size -= CONFIG_OPTEE_TZDRAM_SIZE; +#endif + return 0; }
On Wed, Aug 25, 2021 at 04:22:55PM +0300, Oleksandr Suvorov wrote:
From: Ricardo Salveti ricardo@foundries.io
On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid conflicts.
Note the OPTEE boot process itself subtracts the DRAM region it lives in from the memory map passed to Linux.
Is this something true of all OP-TEE? All OP-TEE on ARMv7? All OP-TEE on i.MX7? I'm asking since currently this hook is done the exact same way on a few other i.MX7 boards, and nowhere else. That says to me we should probably move this hook up somewhere, perhaps to imx_ddr_size() and poke the boards that aren't using that today to use it.
Hi Tom,
On Wed, Aug 25, 2021 at 4:46 PM Tom Rini trini@konsulko.com wrote:
On Wed, Aug 25, 2021 at 04:22:55PM +0300, Oleksandr Suvorov wrote:
From: Ricardo Salveti ricardo@foundries.io
On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid conflicts.
Note the OPTEE boot process itself subtracts the DRAM region it lives in from the memory map passed to Linux.
Is this something true of all OP-TEE? All OP-TEE on ARMv7? All OP-TEE on i.MX7? I'm asking since currently this hook is done the exact same way on a few other i.MX7 boards, and nowhere else. That says to me we should probably move this hook up somewhere, perhaps to imx_ddr_size() and poke the boards that aren't using that today to use it.
Shortly, no. There are different solutions for different boards and they seem not vendor-specific. Say, solutions for both stm32mp1 and zynqmp boards use fdt's reserve memory section to avoid conflicts with the OP-TEE memory region. We're thinking about providing a generic solution, but it will take some time and can't be done right now.
-- Tom
-- Best regards,
Oleksandr Suvorov Software Engineer W: www.foundries.io
On Wed, Aug 25, 2021 at 06:35:05PM +0300, Oleksandr Suvorov wrote:
Hi Tom,
On Wed, Aug 25, 2021 at 4:46 PM Tom Rini trini@konsulko.com wrote:
On Wed, Aug 25, 2021 at 04:22:55PM +0300, Oleksandr Suvorov wrote:
From: Ricardo Salveti ricardo@foundries.io
On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid conflicts.
Note the OPTEE boot process itself subtracts the DRAM region it lives in from the memory map passed to Linux.
Is this something true of all OP-TEE? All OP-TEE on ARMv7? All OP-TEE on i.MX7? I'm asking since currently this hook is done the exact same way on a few other i.MX7 boards, and nowhere else. That says to me we should probably move this hook up somewhere, perhaps to imx_ddr_size() and poke the boards that aren't using that today to use it.
Shortly, no. There are different solutions for different boards and they seem not vendor-specific. Say, solutions for both stm32mp1 and zynqmp boards use fdt's reserve memory section to avoid conflicts with the OP-TEE memory region. We're thinking about providing a generic solution, but it will take some time and can't be done right now.
So it's board-specific up at the OP-TEE level? OK, sigh. This is fine then. Thanks.
Hi Oleksandr,
On Wed, Aug 25, 2021 at 10:37 AM Oleksandr Suvorov oleksandr.suvorov@foundries.io wrote:
From: Ricardo Salveti ricardo@foundries.io
On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid conflicts.
Note the OPTEE boot process itself subtracts the DRAM region it lives in from the memory map passed to Linux.
Signed-off-by: Ricardo Salveti ricardo@foundries.io
You missed adding your own Signed-off-by here.
With this fixed:
Reviewed-by: Fabio Estevam festevam@gmail.com
participants (3)
-
Fabio Estevam -
Oleksandr Suvorov -
Tom Rini