[U-Boot] [PATCH 1/3] mips: ath79: Fix compiler warning on const assignment
The assignment const T var; var = value; is illegal, since var is constant. Drop the const to fix the compiler warning.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com --- arch/mips/mach-ath79/reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c index 504b833..e8f5796 100644 --- a/arch/mips/mach-ath79/reset.c +++ b/arch/mips/mach-ath79/reset.c @@ -46,7 +46,7 @@ void _machine_restart(void)
u32 get_bootstrap(void) { - const void __iomem *base; + void __iomem *base; u32 reg = 0;
base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option is bogus. The DRAM is not active when this option comes into play, so any attempt to restore valid cache state from invalid DRAM must fail. Disable this option to prevent such failure and potential undefined behavior.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com --- arch/mips/mach-ath79/Kconfig | 2 -- 1 file changed, 2 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index f61efd2..95f7de9 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -12,7 +12,6 @@ config SOC_AR933X select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2 - select SYS_MIPS_CACHE_INIT_RAM_LOAD select MIPS_TUNE_24KC help This supports QCA/Atheros ar933x family SOCs. @@ -22,7 +21,6 @@ config SOC_QCA953X select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2 - select SYS_MIPS_CACHE_INIT_RAM_LOAD select MIPS_TUNE_24KC help This supports QCA/Atheros qca953x family SOCs.
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option is bogus. The DRAM is not active when this option comes into play, so any attempt to restore valid cache state from invalid DRAM must fail. Disable this option to prevent such failure and potential undefined behavior.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 2 -- 1 file changed, 2 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index f61efd2..95f7de9 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -12,7 +12,6 @@ config SOC_AR933X select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2
- select SYS_MIPS_CACHE_INIT_RAM_LOAD select MIPS_TUNE_24KC help This supports QCA/Atheros ar933x family SOCs.
@@ -22,7 +21,6 @@ config SOC_QCA953X select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2
- select SYS_MIPS_CACHE_INIT_RAM_LOAD select MIPS_TUNE_24KC help This supports QCA/Atheros qca953x family SOCs.
I will remove this option in the coming v8.
On Thursday, January 28, 2016 at 02:25:08 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option is bogus. The DRAM is not active when this option comes into play, so any attempt to restore valid cache state from invalid DRAM must fail. Disable this option to prevent such failure and potential undefined behavior.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 2 -- 1 file changed, 2 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index f61efd2..95f7de9 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -12,7 +12,6 @@ config SOC_AR933X
select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2
select SYS_MIPS_CACHE_INIT_RAM_LOAD
select MIPS_TUNE_24KC help
This supports QCA/Atheros ar933x family SOCs.
@@ -22,7 +21,6 @@ config SOC_QCA953X
select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2
select SYS_MIPS_CACHE_INIT_RAM_LOAD
select MIPS_TUNE_24KC help
This supports QCA/Atheros qca953x family SOCs.
I will remove this option in the coming v8.
Fine
Best regards, Marek Vasut
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com --- arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@ menu "QCA/Athroes 7xxx/9xxx platforms" depends on ARCH_ATH79
-config SYS_VENDOR - default "ath79" - -config SYS_SOC - default "ath79" - config SOC_AR933X bool select SUPPORTS_BIG_ENDIAN diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@ if BOARD_AP121
+config SYS_VENDOR + default "ath79" + +config SYS_SOC + default "ath79" + config SYS_BOARD default "ap121"
diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@ if BOARD_AP143
+config SYS_VENDOR + default "ath79" + +config SYS_SOC + default "ath79" + config SYS_BOARD default "ap143"
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@ menu "QCA/Athroes 7xxx/9xxx platforms" depends on ARCH_ATH79
-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
- default "ath79"
- config SOC_AR933X bool select SUPPORTS_BIG_ENDIAN
diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@ if BOARD_AP121
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
- default "ath79"
- config SYS_BOARD default "ap121"
diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@ if BOARD_AP143
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
- default "ath79"
- config SYS_BOARD default "ap143"
I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@ menu "QCA/Athroes 7xxx/9xxx platforms" depends on ARCH_ATH79
-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
- default "ath79"
- config SOC_AR933X bool select SUPPORTS_BIG_ENDIAN
diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@ if BOARD_AP121
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
- default "ath79"
- config SYS_BOARD default "ap121"
diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@ if BOARD_AP143
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
- default "ath79"
- config SYS_BOARD default "ap143"
I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
On Thursday, January 28, 2016 at 02:31:11 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@
menu "QCA/Athroes 7xxx/9xxx platforms"
depends on ARCH_ATH79
-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
default "ath79"
config SOC_AR933X
bool select SUPPORTS_BIG_ENDIAN
diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP121
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap121"
diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP143
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap143"
I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
That's fine, but keep this patch or something along those lines, since I want to create board/arduino/yun/ soon after your stuff is accepted.
btw. I got both EHCI and ethernet operational, but I am still struggling with booting the board from the SPI NOR. I think there's something broken in start.S or lowlevel_init.S . Which board do you use for your development and testing ?
On Thursday, January 28, 2016 09:44 PM, Marek Vasut wrote:
On Thursday, January 28, 2016 at 02:31:11 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@
menu "QCA/Athroes 7xxx/9xxx platforms"
depends on ARCH_ATH79-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
default "ath79"
config SOC_AR933X
bool select SUPPORTS_BIG_ENDIAN
diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP121
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap121"
diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP143
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap143"
I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
That's fine, but keep this patch or something along those lines, since I want to create board/arduino/yun/ soon after your stuff is accepted.
btw. I got both EHCI and ethernet operational, but I am still struggling with booting the board from the SPI NOR. I think there's something broken in start.S or lowlevel_init.S . Which board do you use for your development and testing ?
My private board was made by myself, it originate from AP121, and it's circuit is compatible with AP121.
On Thursday, January 28, 2016 at 03:43:58 PM, Wills Wang wrote:
On Thursday, January 28, 2016 09:44 PM, Marek Vasut wrote:
On Thursday, January 28, 2016 at 02:31:11 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@
menu "QCA/Athroes 7xxx/9xxx platforms"
depends on ARCH_ATH79-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
default "ath79"
config SOC_AR933X
bool select SUPPORTS_BIG_ENDIAN
diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP121
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap121"
diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP143
+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap143"
I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
That's fine, but keep this patch or something along those lines, since I want to create board/arduino/yun/ soon after your stuff is accepted.
btw. I got both EHCI and ethernet operational, but I am still struggling with booting the board from the SPI NOR. I think there's something broken in start.S or lowlevel_init.S . Which board do you use for your development and testing ?
My private board was made by myself, it originate from AP121, and it's circuit is compatible with AP121.
How do you program your board ? Do you have EJTAG?
What SPI NOR do you use?
On Thursday, January 28, 2016 10:53 PM, Marek Vasut wrote:
On Thursday, January 28, 2016 at 03:43:58 PM, Wills Wang wrote:
On Thursday, January 28, 2016 09:44 PM, Marek Vasut wrote:
On Thursday, January 28, 2016 at 02:31:11 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@
menu "QCA/Athroes 7xxx/9xxx platforms" depends on ARCH_ATH79-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
default "ath79"
config SOC_AR933X
bool select SUPPORTS_BIG_ENDIANdiff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP121+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap121"diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP143+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap143"I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
That's fine, but keep this patch or something along those lines, since I want to create board/arduino/yun/ soon after your stuff is accepted.
btw. I got both EHCI and ethernet operational, but I am still struggling with booting the board from the SPI NOR. I think there's something broken in start.S or lowlevel_init.S . Which board do you use for your development and testing ?
My private board was made by myself, it originate from AP121, and it's circuit is compatible with AP121.
How do you program your board ? Do you have EJTAG?
What SPI NOR do you use?
My flash chip is W25Q64FV. I place a chip socket on board, flash chip can be plugged in or out easily.
On Friday, January 29, 2016 at 09:46:24 AM, Wills Wang wrote:
On Thursday, January 28, 2016 10:53 PM, Marek Vasut wrote:
On Thursday, January 28, 2016 at 03:43:58 PM, Wills Wang wrote:
On Thursday, January 28, 2016 09:44 PM, Marek Vasut wrote:
On Thursday, January 28, 2016 at 02:31:11 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/Kconfig | 6 ------ board/ath79/ap121/Kconfig | 6 ++++++ board/ath79/ap143/Kconfig | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-)diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644 --- a/arch/mips/mach-ath79/Kconfig +++ b/arch/mips/mach-ath79/Kconfig @@ -1,12 +1,6 @@
menu "QCA/Athroes 7xxx/9xxx platforms" depends on ARCH_ATH79-config SYS_VENDOR
- default "ath79"
-config SYS_SOC
default "ath79"
config SOC_AR933X
bool select SUPPORTS_BIG_ENDIANdiff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig index ec72914..a4e5690 100644 --- a/board/ath79/ap121/Kconfig +++ b/board/ath79/ap121/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP121+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap121"diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig index 118b9b5..2e54fa7 100644 --- a/board/ath79/ap143/Kconfig +++ b/board/ath79/ap143/Kconfig @@ -1,5 +1,11 @@
if BOARD_AP143+config SYS_VENDOR
- default "ath79"
+config SYS_SOC
default "ath79"
config SYS_BOARD
default "ap143"I plan to place ap121 and ap143 into board/qca, and then move these into board directory.
That's fine, but keep this patch or something along those lines, since I want to create board/arduino/yun/ soon after your stuff is accepted.
btw. I got both EHCI and ethernet operational, but I am still struggling with booting the board from the SPI NOR. I think there's something broken in start.S or lowlevel_init.S . Which board do you use for your development and testing ?
My private board was made by myself, it originate from AP121, and it's circuit is compatible with AP121.
How do you program your board ? Do you have EJTAG?
What SPI NOR do you use?
My flash chip is W25Q64FV. I place a chip socket on board, flash chip can be plugged in or out easily.
I see, OK.
Just out of sheer curiosity, are you doing the ath79 support as a hobby thing or are you putting out an actual product ?
Also, you might want to join the u-boot IRC, it's easier to discuss things in real time.
Best regards, Marek Vasut
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
The assignment const T var; var = value; is illegal, since var is constant. Drop the const to fix the compiler warning.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c index 504b833..e8f5796 100644 --- a/arch/mips/mach-ath79/reset.c +++ b/arch/mips/mach-ath79/reset.c @@ -46,7 +46,7 @@ void _machine_restart(void)
u32 get_bootstrap(void) {
- const void __iomem *base;
void __iomem *base; u32 reg = 0;
base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
I have dropped "const" in the coming v8.
On Thursday, January 28, 2016 at 02:23:48 PM, Wills Wang wrote:
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
The assignment const T var; var = value; is illegal, since var is constant. Drop the const to fix the compiler warning.
Signed-off-by: Marek Vasut marex@denx.de Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Wills Wang wills.wang@live.com
arch/mips/mach-ath79/reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c index 504b833..e8f5796 100644 --- a/arch/mips/mach-ath79/reset.c +++ b/arch/mips/mach-ath79/reset.c @@ -46,7 +46,7 @@ void _machine_restart(void)
u32 get_bootstrap(void) {
- const void __iomem *base;
void __iomem *base;
u32 reg = 0;
base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
I have dropped "const" in the coming v8.
Fine
Best regards, Marek Vasut
participants (2)
-
Marek Vasut -
Wills Wang