Don't use sudo in python tests
Hello Simon,
As described in doc/develop/py_testing.doc using sudo in python tests should be avoided.
* users building U-Boot may not be sudoers * running code as sudo comes with a risk
You added sudo in test/py/tests/test_ut.py
Can we use virt-make-fs here?
Best regards
Heinrich
On Sat, Oct 22, 2022 at 10:24:33AM +0200, Heinrich Schuchardt wrote:
Hello Simon,
As described in doc/develop/py_testing.doc using sudo in python tests should be avoided.
- users building U-Boot may not be sudoers
- running code as sudo comes with a risk
You added sudo in test/py/tests/test_ut.py
Can we use virt-make-fs here?
Note that virt-make-fs is only suitable for trivial cases as it's otherwise too slow. This is possibly one of the cases where it's too slow.
On 10/22/22 08:04, Tom Rini wrote:
On Sat, Oct 22, 2022 at 10:24:33AM +0200, Heinrich Schuchardt wrote:
Hello Simon,
As described in doc/develop/py_testing.doc using sudo in python tests should be avoided.
- users building U-Boot may not be sudoers
- running code as sudo comes with a risk
You added sudo in test/py/tests/test_ut.py
Can we use virt-make-fs here?
Note that virt-make-fs is only suitable for trivial cases as it's otherwise too slow. This is possibly one of the cases where it's too slow.
An easy way to do this is to use fuse2fs/fusefat.
--Sean
On Sat, Oct 22, 2022 at 02:44:27PM -0400, Sean Anderson wrote:
On 10/22/22 08:04, Tom Rini wrote:
On Sat, Oct 22, 2022 at 10:24:33AM +0200, Heinrich Schuchardt wrote:
Hello Simon,
As described in doc/develop/py_testing.doc using sudo in python tests should be avoided.
- users building U-Boot may not be sudoers
- running code as sudo comes with a risk
You added sudo in test/py/tests/test_ut.py
Can we use virt-make-fs here?
Note that virt-make-fs is only suitable for trivial cases as it's otherwise too slow. This is possibly one of the cases where it's too slow.
An easy way to do this is to use fuse2fs/fusefat.
I guess at this point some patches to migrate a test or two over, so we can see how they perform, would be much appreciated.
Am 22. Oktober 2022 20:44:27 MESZ schrieb Sean Anderson seanga2@gmail.com:
On 10/22/22 08:04, Tom Rini wrote:
On Sat, Oct 22, 2022 at 10:24:33AM +0200, Heinrich Schuchardt wrote:
Hello Simon,
As described in doc/develop/py_testing.doc using sudo in python tests should be avoided.
- users building U-Boot may not be sudoers
- running code as sudo comes with a risk
You added sudo in test/py/tests/test_ut.py
Can we use virt-make-fs here?
Note that virt-make-fs is only suitable for trivial cases as it's otherwise too slow. This is possibly one of the cases where it's too slow.
An easy way to do this is to use fuse2fs/fusefat.
My experience with fusefat is that it was terribly buggy 2-3 years ago.
Last upstream source is from 2018.
Best regards
Heinrich
--Sean
On 10/22/22 18:00, Heinrich Schuchardt wrote:
Am 22. Oktober 2022 20:44:27 MESZ schrieb Sean Anderson seanga2@gmail.com:
On 10/22/22 08:04, Tom Rini wrote:
On Sat, Oct 22, 2022 at 10:24:33AM +0200, Heinrich Schuchardt wrote:
Hello Simon,
As described in doc/develop/py_testing.doc using sudo in python tests should be avoided.
- users building U-Boot may not be sudoers
- running code as sudo comes with a risk
You added sudo in test/py/tests/test_ut.py
Can we use virt-make-fs here?
Note that virt-make-fs is only suitable for trivial cases as it's otherwise too slow. This is possibly one of the cases where it's too slow.
An easy way to do this is to use fuse2fs/fusefat.
My experience with fusefat is that it was terribly buggy 2-3 years ago.
Last upstream source is from 2018.
Yeah, I had not used it before. fuse2fs is nice. It doesn't support replaying the journal, but this doesn't matter when creating a filesystem.
mtools seems incredibly clunky, but it appears to work, and has reasonable performance.
LKL [1] seemed like it might have been the most robust solution (with lklfuse), but it hasn't made it upstream yet (and the primary author seems to have stopped trying).
--Sean
participants (3)
-
Heinrich Schuchardt -
Sean Anderson -
Tom Rini