[U-Boot] [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
From: Radu Bacrau dumitru.bacrau@intel.com
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by: Radu Bacrau dumitru.bacrau@intel.com Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Jagan Teki jteki@openedev.com Cc: Radu Bacrau radu.bacrau@gmail.com --- drivers/mtd/spi/sf_params.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 5b50114..8b50465 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, RD_FULL | WR_QPP}, {"MX25L51235F", 0xc2201a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, RD_FULL | WR_QPP}, + {"MX66U51235F", 0xc2253a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP}, + {"MX66L1G45G", 0xc2201b, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP}, #endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0}, @@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = { {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K}, + {"MT25QU02G", 0x20bb22, 0x0, 64 * 1024, 4096, RD_FULL | WR_QPP | E_FSR | SECT_4K}, #endif #ifdef CONFIG_SPI_FLASH_SST /* SST */ {"SST25VF040B", 0xbf258d, 0x0, 64 * 1024, 8, SECT_4K | SST_WR},
On Wed, 2016-10-12 at 09:15 -0500, dumitru.bacrau@intel.com wrote:
From: Radu Bacrau dumitru.bacrau@intel.com
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by: Radu Bacrau dumitru.bacrau@intel.com Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Jagan Teki jteki@openedev.com Cc: Radu Bacrau radu.bacrau@gmail.com
drivers/mtd/spi/sf_params.c | 3 +++ 1 file changed, 3 insertions(+)
Reviewed-by: Chin Liang See clsee@altera.com
Thanks Chin Liang
On Wed, Oct 12, 2016 at 7:45 PM, dumitru.bacrau@intel.com wrote:
From: Radu Bacrau dumitru.bacrau@intel.com
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by: Radu Bacrau dumitru.bacrau@intel.com Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Jagan Teki jteki@openedev.com Cc: Radu Bacrau radu.bacrau@gmail.com
drivers/mtd/spi/sf_params.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 5b50114..8b50465 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, RD_FULL | WR_QPP}, {"MX25L51235F", 0xc2201a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, RD_FULL | WR_QPP},
{"MX66U51235F", 0xc2253a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP},{"MX66L1G45G", 0xc2201b, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP},
OK.
#endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0}, @@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = { {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
{"MT25QU02G", 0x20bb22, 0x0, 64 * 1024, 4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},
Can you send the link for flash data sheet I couldn't find it.
thanks!
Hello Teki,
The device that I have used is MT25QU02GCBB8E12-0SIT, with the datasheet available here: https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/seria....
Thanks a lot, Radu
-----Original Message----- From: Jagan Teki [mailto:jagan@openedev.com] Sent: Wednesday, October 26, 2016 2:25 AM To: Bacrau, Dumitru dumitru.bacrau@intel.com Cc: u-boot@lists.denx.de; Chin Liang See clsee@altera.com; Dinh Nguyen dinguyen@opensource.altera.com; Radu Bacrau radu.bacrau@gmail.com Subject: Re: [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
On Wed, Oct 12, 2016 at 7:45 PM, dumitru.bacrau@intel.com wrote:
From: Radu Bacrau dumitru.bacrau@intel.com
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by: Radu Bacrau dumitru.bacrau@intel.com Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Jagan Teki jteki@openedev.com Cc: Radu Bacrau radu.bacrau@gmail.com
drivers/mtd/spi/sf_params.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 5b50114..8b50465 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, RD_FULL | WR_QPP}, {"MX25L51235F", 0xc2201a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, RD_FULL | WR_QPP},
{"MX66U51235F", 0xc2253a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP},{"MX66L1G45G", 0xc2201b, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP},
OK.
#endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0}, @@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = { {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
{"MT25QU02G", 0x20bb22, 0x0, 64 * 1024, 4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},
Can you send the link for flash data sheet I couldn't find it.
thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.
On Wed, Oct 26, 2016 at 9:18 PM, Bacrau, Dumitru dumitru.bacrau@intel.com wrote:
Hello Teki,
The device that I have used is MT25QU02GCBB8E12-0SIT, with the datasheet available here: https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/seria....
Thanks.
-----Original Message----- From: Jagan Teki [mailto:jagan@openedev.com] Sent: Wednesday, October 26, 2016 2:25 AM To: Bacrau, Dumitru dumitru.bacrau@intel.com Cc: u-boot@lists.denx.de; Chin Liang See clsee@altera.com; Dinh Nguyen dinguyen@opensource.altera.com; Radu Bacrau radu.bacrau@gmail.com Subject: Re: [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
On Wed, Oct 12, 2016 at 7:45 PM, dumitru.bacrau@intel.com wrote:
From: Radu Bacrau dumitru.bacrau@intel.com
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by: Radu Bacrau dumitru.bacrau@intel.com Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Jagan Teki jteki@openedev.com Cc: Radu Bacrau radu.bacrau@gmail.com
drivers/mtd/spi/sf_params.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 5b50114..8b50465 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, RD_FULL | WR_QPP}, {"MX25L51235F", 0xc2201a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, RD_FULL | WR_QPP},
{"MX66U51235F", 0xc2253a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP},{"MX66L1G45G", 0xc2201b, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP},OK.
#endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0}, @@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = { {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
{"MT25QU02G", 0x20bb22, 0x0, 64 * 1024, 4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},
Since it's bb 1.8v we usually differentiate to use 'A' at the end of the name like N25Q1024 - 0x20ba N25Q1024A - 0x20bb
So, we need append A at end of the name - MT25QU02GA. If you agree please try to send the next version with this update.
thanks!
Hi Teki,
Sure, I can do that, but here is more information, maybe we can come up with a better solution:
For this device, the "U" in the part name means "1.8V". The equivalent 3.3V part has "L" in the part name. So I would prefer having the names: - MT25QL02G - for 3.3V device - MT25QU02G - for the 1.8V device
The advantages of this naming is that the string is easily searchable on the web (for example if you search for N25Q1024 you will not find it on the Micron website).
If that is not acceptable, then I would suggest the following alternative (without 'U' or 'L'): - MT25Q02G - for 3.3V device - MT25Q02GA - for the 1.8V device
Just let me know which one you prefer, and I will re-submit. I can include the 3.3V part according to datasheet, although I cannot test it.
Thank you, Radu
-----Original Message----- From: Jagan Teki [mailto:jagan@openedev.com] Sent: Wednesday, October 26, 2016 12:53 PM To: Bacrau, Dumitru dumitru.bacrau@intel.com Cc: u-boot@lists.denx.de; Radu Bacrau radu.bacrau@gmail.com; Chin Liang See clsee@altera.com Subject: Re: [U-Boot] [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
On Wed, Oct 26, 2016 at 9:18 PM, Bacrau, Dumitru dumitru.bacrau@intel.com wrote:
Hello Teki,
The device that I have used is MT25QU02GCBB8E12-0SIT, with the datasheet available here: https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/seria....
Thanks.
-----Original Message----- From: Jagan Teki [mailto:jagan@openedev.com] Sent: Wednesday, October 26, 2016 2:25 AM To: Bacrau, Dumitru dumitru.bacrau@intel.com Cc: u-boot@lists.denx.de; Chin Liang See clsee@altera.com; Dinh Nguyen dinguyen@opensource.altera.com; Radu Bacrau radu.bacrau@gmail.com Subject: Re: [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
On Wed, Oct 12, 2016 at 7:45 PM, dumitru.bacrau@intel.com wrote:
From: Radu Bacrau dumitru.bacrau@intel.com
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by: Radu Bacrau dumitru.bacrau@intel.com Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Jagan Teki jteki@openedev.com Cc: Radu Bacrau radu.bacrau@gmail.com
drivers/mtd/spi/sf_params.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 5b50114..8b50465 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, RD_FULL | WR_QPP}, {"MX25L51235F", 0xc2201a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, RD_FULL | WR_QPP},
{"MX66U51235F", 0xc2253a, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP},{"MX66L1G45G", 0xc2201b, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP},OK.
#endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0}, @@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = { {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K}, {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
{"MT25QU02G", 0x20bb22, 0x0, 64 * 1024, 4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},
Since it's bb 1.8v we usually differentiate to use 'A' at the end of the name like N25Q1024 - 0x20ba N25Q1024A - 0x20bb
So, we need append A at end of the name - MT25QU02GA. If you agree please try to send the next version with this update.
thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.
On Thu, Oct 27, 2016 at 3:48 AM, Bacrau, Dumitru dumitru.bacrau@intel.com wrote:
Hi Teki,
Sure, I can do that, but here is more information, maybe we can come up with a better solution:
For this device, the "U" in the part name means "1.8V". The equivalent 3.3V part has "L" in the part name. So I would prefer having the names:
- MT25QL02G - for 3.3V device
- MT25QU02G - for the 1.8V device
The advantages of this naming is that the string is easily searchable on the web (for example if you search for N25Q1024 you will not find it on the Micron website).
Sounds valid, submit with these changes, thanks.
participants (4)
-
Bacrau, Dumitru -
Chin Liang See -
dumitru.bacrau＠intel.com
-
Jagan Teki