[U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din
Signed-off-by: Axel Lin axel.lin@ingics.com --- drivers/spi/armada100_spi.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c index afdbe05..b237c7c 100644 --- a/drivers/spi/armada100_spi.c +++ b/drivers/spi/armada100_spi.c @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, goto done; }
- if (dout) - pss->tx = dout; - else - pss->tx = NULL; - - if (din) - pss->rx = din; - else - pss->rx = NULL; + pss->tx = dout; + pss->rx = din;
if (flags & SPI_XFER_BEGIN) { spi_cs_activate(slave);
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel.lin@ingics.com wrote:
Signed-off-by: Axel Lin axel.lin@ingics.com
Reviewed-by: Simon Glass sjg@chromium.org
drivers/spi/armada100_spi.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c index afdbe05..b237c7c 100644 --- a/drivers/spi/armada100_spi.c +++ b/drivers/spi/armada100_spi.c @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, goto done; }
if (dout)pss->tx = dout;elsepss->tx = NULL;if (din)pss->rx = din;elsepss->rx = NULL;
pss->tx = dout;pss->rx = din; if (flags & SPI_XFER_BEGIN) { spi_cs_activate(slave);-- 1.8.1.2
Dear Simon Glass,
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel.lin@ingics.com wrote:
Signed-off-by: Axel Lin axel.lin@ingics.com
Reviewed-by: Simon Glass sjg@chromium.org
Reviewed-by: Marek Vasut marex@denx.de
Best regards, Marek Vasut
----- "Marek Vasut" marex@denx.de wrote:
Dear Simon Glass,
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel.lin@ingics.com
wrote:
Signed-off-by: Axel Lin axel.lin@ingics.com
Reviewed-by: Simon Glass sjg@chromium.org
Reviewed-by: Marek Vasut marex@denx.de
Acked-by: Ajay Bhargav ajay.bhargav@einfochips.com
Regards, Ajay Bhargav
--------------------------------------------------------------------------------------------- Notice: This message has been scanned by Trend Micro Mail Security scanner and is believed to be clean ---------------------------------------------------------------------------------------------
On 12-06-2013 15:49, Ajay Bhargav wrote:
----- "Marek Vasut" marex@denx.de wrote:
Dear Simon Glass,
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel.lin@ingics.com
wrote:
Signed-off-by: Axel Lin axel.lin@ingics.com
Reviewed-by: Simon Glass sjg@chromium.org
Reviewed-by: Marek Vasut marex@denx.de
Acked-by: Ajay Bhargav ajay.bhargav@einfochips.com
Regards, Ajay Bhargav
Notice: This message has been scanned by Trend Micro Mail Security scanner and is believed to be clean
Reviewed-by: Jagannadha Sutradharudu Teki jagannadh.teki@gmail.com
-- Thanks, Jagan.
On 11-06-2013 19:27, Axel Lin wrote:
Signed-off-by: Axel Lin axel.lin@ingics.com Reviewed-by: Marek Vasut marex@denx.de Acked-by: Ajay Bhargav ajay.bhargav@einfochips.com Reviewed-by: Jagannadha Sutradharudu Teki jagannadh.teki@gmail.com
drivers/spi/armada100_spi.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c index afdbe05..b237c7c 100644 --- a/drivers/spi/armada100_spi.c +++ b/drivers/spi/armada100_spi.c @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, goto done; }
- if (dout)
pss->tx = dout;- else
pss->tx = NULL;- if (din)
pss->rx = din;- else
pss->rx = NULL;
pss->tx = dout;
pss->rx = din;
if (flags & SPI_XFER_BEGIN) { spi_cs_activate(slave);
Applied to u-boot-spi/master
-- Thanks, Jagan.
participants (5)
-
Ajay Bhargav -
Axel Lin -
Jagan Teki -
Marek Vasut -
Simon Glass