Old regression possibly affecting many devices with build options in Kconfig files
Hello,
On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.
Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.
I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.
My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.
Realtek PHY is disabled in defconfig and Gigabit Ethernet support doesn't work. Re-enable PHY options to fix this.
Signed-off-by: Anatolij Gustschin agust@denx.de Reported-by: Dario dario86@tutamail.com Fixes: af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB") Fixes: 8728c97eff5b ("configs: Re-sync") --- Cc'ing board & sunxi maintainers. I do not have this board, so please test if this patch helps to fix broken gigabit ethernet. Thanks!
configs/A20-OLinuXino-Lime2_defconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig index 2b082cab59..28b558cbeb 100644 --- a/configs/A20-OLinuXino-Lime2_defconfig +++ b/configs/A20-OLinuXino-Lime2_defconfig @@ -18,6 +18,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2" CONFIG_SCSI_AHCI=y CONFIG_DFU_RAM=y CONFIG_FASTBOOT_CMD_OEM_FORMAT=y +CONFIG_PHY_REALTEK=y +CONFIG_RTL8211X_PHY_FORCE_MASTER=y CONFIG_ETH_DESIGNWARE=y CONFIG_RGMII=y CONFIG_MII=y diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 0ef289fd64..f4bbce8443 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -273,8 +273,10 @@ extern int soft_i2c_gpio_scl; /* Ethernet support */
#ifdef CONFIG_SUN7I_GMAC +#ifndef CONFIG_PHY_REALTEK #define CONFIG_PHY_REALTEK #endif +#endif
#ifdef CONFIG_USB_EHCI_HCD #define CONFIG_USB_OHCI_NEW
On Fri, Apr 24, 2020 at 5:24 PM Anatolij Gustschin agust@denx.de wrote:
Realtek PHY is disabled in defconfig and Gigabit Ethernet support doesn't work. Re-enable PHY options to fix this.
Signed-off-by: Anatolij Gustschin agust@denx.de Reported-by: Dario dario86@tutamail.com Fixes: af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB") Fixes: 8728c97eff5b ("configs: Re-sync")
Please rebase on master and send. fyi, I don't have board accessibility right now to test this.
Jagan.
On Fri, 1 May 2020 22:16:16 +0530 Jagan Teki jagan@amarulasolutions.com wrote: ...
Please rebase on master and send. fyi, I don't have board accessibility right now to test this.
This patch should be dropped. Tom already fixed this issue, please see commit 69a229c6d4b4.
-- Anatolij
Hi Dario,
On Thu, 23 Apr 2020 19:27:23 +0200 (CEST) Dario dario86@tutamail.com wrote:
Hello,
On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.
Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.
since the first mentioned commit CONFIG_RTL8211X_PHY_FORCE_MASTER depends on CONFIG_PHY_REALTEK, but this was not enabled in board defconfig. This is probably the reason why it was dropped in 8728c97eff5b.
I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.
My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.
Please test patch [1]. If it helps, we can see how to fix other boards. When reporting, please also Cc board maintainers (see board/sunxi/MAINTAINERS). Thanks!
[1] http://patchwork.ozlabs.org/project/uboot/patch/20200424115411.11102-1-agust...
-- Anatolij
On Fri, Apr 24, 2020 at 02:04:57PM +0200, Anatolij Gustschin wrote:
Hi Dario,
On Thu, 23 Apr 2020 19:27:23 +0200 (CEST) Dario dario86@tutamail.com wrote:
Hello,
On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.
Thanks for the regression report. We do appreciate these whenever they come in.
Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.
since the first mentioned commit CONFIG_RTL8211X_PHY_FORCE_MASTER depends on CONFIG_PHY_REALTEK, but this was not enabled in board defconfig. This is probably the reason why it was dropped in 8728c97eff5b.
Right, it got removed because it couldn't be selected anymore. This means that the first commit didn't move everything right.
I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.
My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.
Please test patch [1]. If it helps, we can see how to fix other boards. When reporting, please also Cc board maintainers (see board/sunxi/MAINTAINERS). Thanks!
[1] http://patchwork.ozlabs.org/project/uboot/patch/20200424115411.11102-1-agust...
Please let us know if that works but I'm going to take a look at what else might be broken by the first commit and the patch above implies we need to migrate that symbol in a few more cases.
Your patch works. Thank you!
This is the first time I post a bug report on a mailing list. I hope I have included the right recipients.
The network adapter of this board is affected by another bug for which I have found a partial solution. I will send a separate message to discuss the issue.
24 apr 2020, 14:04 da agust@denx.de:
Hi Dario,
On Thu, 23 Apr 2020 19:27:23 +0200 (CEST) Dario dario86@tutamail.com wrote:
Hello,
On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.
Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.
since the first mentioned commit CONFIG_RTL8211X_PHY_FORCE_MASTER depends on CONFIG_PHY_REALTEK, but this was not enabled in board defconfig. This is probably the reason why it was dropped in 8728c97eff5b.
I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.
My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.
Please test patch [1]. If it helps, we can see how to fix other boards. When reporting, please also Cc board maintainers (see board/sunxi/MAINTAINERS). Thanks!
[1] http://patchwork.ozlabs.org/project/uboot/patch/20200424115411.11102-1-agust...
-- Anatolij
participants (4)
-
Anatolij Gustschin -
Dario -
Jagan Teki -
Tom Rini