[U-Boot] [PATCH] ARM: kirkwood: remove obsolete call to icache_enable

Commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") changed cache setup for Kirkwood such that icache_enable() is now called from enable_caches() which is called from initr_caches() which is in the list of functions in init_sequence_r[] prior to arch_misc_init(). This means the call to icache_enable() in arch_misc_init() is no longer required, so remove it.
Signed-off-by: Leigh Brown leigh@solinno.co.uk ---
diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c index d54de53f31..8a065d73ae 100644 --- a/arch/arm/mach-kirkwood/cpu.c +++ b/arch/arm/mach-kirkwood/cpu.c @@ -291,7 +291,6 @@ int arch_misc_init(void) temp |= (1 << 22); writefr_extra_feature_reg(temp);
- icache_enable(); /* Change reset vector to address 0x0 */ temp = get_cr(); set_cr(temp & ~CR_V);

On 19.03.19 15:50, Leigh Brown wrote:
Commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") changed cache setup for Kirkwood such that icache_enable() is now called from enable_caches() which is called from initr_caches() which is in the list of functions in init_sequence_r[] prior to arch_misc_init(). This means the call to icache_enable() in arch_misc_init() is no longer required, so remove it.
Signed-off-by: Leigh Brown leigh@solinno.co.uk
Reviewed-by: Stefan Roese sr@denx.de
I'll push this patch with my next updates in a few days into mainline.
Thanks, Stefan

On 19.03.19 15:50, Leigh Brown wrote:
Commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") changed cache setup for Kirkwood such that icache_enable() is now called from enable_caches() which is called from initr_caches() which is in the list of functions in init_sequence_r[] prior to arch_misc_init(). This means the call to icache_enable() in arch_misc_init() is no longer required, so remove it.
Signed-off-by: Leigh Brown leigh@solinno.co.uk
Applied to u-boot-marvell/master.
Thanks, Stefan
participants (2)
-
Leigh Brown
-
Stefan Roese