[PATCH] net: Add missing PCI dependency for CONFIG_E1000
Signed-off-by: Pali Rohár pali@kernel.org --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 7fe0e00649cf..84d859c21eb8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000 bool "Intel PRO/1000 Gigabit Ethernet support" + depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go
On Mon, May 23, 2022 at 11:42 AM Pali Rohár pali@kernel.org wrote:
Signed-off-by: Pali Rohár pali@kernel.org
drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 7fe0e00649cf..84d859c21eb8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go-- 2.20.1
Reviewed-by: Ramon Fried rfried.dev@gmail.com
Hi Pali,
On 5/23/22 4:41 AM, Pali Rohár wrote:
Signed-off-by: Pali Rohár pali@kernel.org
drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 7fe0e00649cf..84d859c21eb8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
- depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go
This appears to be a duplicate of [1].
[1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.c...
--Sean
On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
Hi Pali,
On 5/23/22 4:41 AM, Pali Rohár wrote:
Signed-off-by: Pali Rohár pali@kernel.org
drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 7fe0e00649cf..84d859c21eb8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
- depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go
This appears to be a duplicate of [1].
[1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.c...
--Sean
Interesting... this is my second duplicate patch this week.
Any idea why above patch was not accepted yet?
I'm just testing U-Boot builds and I hit the same issue in dependency graph.
On 5/24/22 1:16 PM, Pali Rohár wrote:
On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
Hi Pali,
On 5/23/22 4:41 AM, Pali Rohár wrote:
Signed-off-by: Pali Rohár pali@kernel.org
drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 7fe0e00649cf..84d859c21eb8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
- depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go
This appears to be a duplicate of [1].
[1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.c...
--Sean
Interesting... this is my second duplicate patch this week.
Any idea why above patch was not accepted yet?
Looks like Ramon has not done a pull request since mid April [1]. Though based on the past pattern, it seems like he just makes one PR each release. Perhaps Tom can pick this up?
[1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLD...
--Sean
On Tue, May 24, 2022 at 01:32:08PM -0400, Sean Anderson wrote:
On 5/24/22 1:16 PM, Pali Rohár wrote:
On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
Hi Pali,
On 5/23/22 4:41 AM, Pali Rohár wrote:
Signed-off-by: Pali Rohár pali@kernel.org
drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 7fe0e00649cf..84d859c21eb8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
- depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go
This appears to be a duplicate of [1].
[1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.c...
--Sean
Interesting... this is my second duplicate patch this week.
Any idea why above patch was not accepted yet?
Looks like Ramon has not done a pull request since mid April [1]. Though based on the past pattern, it seems like he just makes one PR each release. Perhaps Tom can pick this up?
[1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLD...
Sure. It didn't stand out as a critical thing so I was assuming at the time it would come in eventually. I've put it in my bundle of stuff to not forget.
participants (4)
-
Pali Rohár -
Ramon Fried -
Sean Anderson -
Tom Rini