[PATCH v6 1/2] usb: Update struct usb_device to indicate speed enum
The speed member actually uses an enum, so add this to the comment.
Signed-off-by: Simon Glass sjg@chromium.org ---
Changes in v6: - Use the enum directly in the struct
include/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/usb.h b/include/usb.h index 22f6088fe6..fa9e09607e 100644 --- a/include/usb.h +++ b/include/usb.h @@ -103,7 +103,7 @@ enum { */ struct usb_device { int devnum; /* Device number on USB bus */ - int speed; /* full/low/high */ + enum usb_device_speed speed; /* full/low/high */ char mf[32]; /* manufacturer */ char prod[32]; /* product */ char serial[32]; /* serial number */
Fix a typo in the comment.
Signed-off-by: Simon Glass sjg@chromium.org ---
Changes in v6: None
include/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/pci.h b/include/pci.h index aff56b24f9..19c9244b94 100644 --- a/include/pci.h +++ b/include/pci.h @@ -531,7 +531,7 @@ typedef int pci_dev_t; * This is relevant for the following macros: * PCI_DEV, PCI_FUNC, PCI_DEVFN * The U-Boot macro PCI_DEV is equivalent to the Linux PCI_SLOT version with - * the remark from above (input d in bits 15-8 instead of 7-0. + * the remark from above (input is in bits 15-8 instead of 7-0. */ #define PCI_DEV(d) (((d) >> 11) & 0x1f) #define PCI_FUNC(d) (((d) >> 8) & 0x7)
On Sun, May 10, 2020 at 10:26:54AM -0600, Simon Glass wrote:
Fix a typo in the comment.
Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
On 5/10/20 6:26 PM, Simon Glass wrote:
The speed member actually uses an enum, so add this to the comment.
Signed-off-by: Simon Glass sjg@chromium.org
Reviewed-by: Marek Vasut marex@denx.de
On Sun, May 10, 2020 at 10:26:53AM -0600, Simon Glass wrote:
The speed member actually uses an enum, so add this to the comment.
Signed-off-by: Simon Glass sjg@chromium.org Reviewed-by: Marek Vasut marex@denx.de
Applied to u-boot/master, thanks!
participants (3)
-
Marek Vasut -
Simon Glass -
Tom Rini