[U-Boot] [PATCH 12/31] 82xx, mgcoge: corrected wrong flash sizes

flash size of mgcoge corrected boot to 4M (was 32) cfg to 32M (was 64)
Signed-off-by: Thomas Herzmann thomas.herzmann@keymile.com Signed-off-by: Heiko Schocher hs@denx.de --- include/configs/mgcoge.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h index a754f0b..f307382 100644 --- a/include/configs/mgcoge.h +++ b/include/configs/mgcoge.h @@ -99,14 +99,14 @@
#define CONFIG_SYS_SDRAM_BASE 0x00000000 #define CONFIG_SYS_FLASH_BASE 0xFE000000 -#define CONFIG_SYS_FLASH_SIZE 32 +#define CONFIG_SYS_FLASH_SIZE 4 #define CONFIG_SYS_FLASH_CFI #define CONFIG_FLASH_CFI_DRIVER #define CONFIG_SYS_MAX_FLASH_BANKS 2 /* max num of flash banks */ #define CONFIG_SYS_MAX_FLASH_SECT 512 /* max num of sects on one chip */
#define CONFIG_SYS_FLASH_BASE_1 0x50000000 -#define CONFIG_SYS_FLASH_SIZE_1 64 +#define CONFIG_SYS_FLASH_SIZE_1 32
#define CONFIG_SYS_FLASH_BANKS_LIST { CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE_1 }

Dear Heiko Schocher,
In message 498027D6.3070600@denx.de you wrote:
flash size of mgcoge corrected boot to 4M (was 32) cfg to 32M (was 64)
Signed-off-by: Thomas Herzmann thomas.herzmann@keymile.com Signed-off-by: Heiko Schocher hs@denx.de
include/configs/mgcoge.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h index a754f0b..f307382 100644 --- a/include/configs/mgcoge.h +++ b/include/configs/mgcoge.h @@ -99,14 +99,14 @@
#define CONFIG_SYS_SDRAM_BASE 0x00000000 #define CONFIG_SYS_FLASH_BASE 0xFE000000 -#define CONFIG_SYS_FLASH_SIZE 32 +#define CONFIG_SYS_FLASH_SIZE 4
That's broken. The flash size should never be defined. Why don;t you use auto-detection as U-Boot was designed for?
Best regards,
Wolfgang Denk

Hello Wolfgang,
Wolfgang Denk wrote:
In message 498027D6.3070600@denx.de you wrote:
flash size of mgcoge corrected boot to 4M (was 32) cfg to 32M (was 64)
Signed-off-by: Thomas Herzmann thomas.herzmann@keymile.com Signed-off-by: Heiko Schocher hs@denx.de
include/configs/mgcoge.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h index a754f0b..f307382 100644 --- a/include/configs/mgcoge.h +++ b/include/configs/mgcoge.h @@ -99,14 +99,14 @@
#define CONFIG_SYS_SDRAM_BASE 0x00000000 #define CONFIG_SYS_FLASH_BASE 0xFE000000 -#define CONFIG_SYS_FLASH_SIZE 32 +#define CONFIG_SYS_FLASH_SIZE 4
That's broken. The flash size should never be defined. Why don;t you use auto-detection as U-Boot was designed for?
I use the CFI driver ... have to check for what this defines are used (Hopefully they are no more used).
Argh... i used it.
I change this.
thanks Heiko
participants (2)
-
Heiko Schocher
-
Wolfgang Denk