[U-Boot] [PATCH v2] NAND: show manufacturer and device ID for unknown chips

From: Florian Fainelli florian@openwrt.org
When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.
Signed-off-by: Florian Fainelli f.fainelli@gmail.com Signed-off-by: Scott Wood scottwood@freescale.com --- Whitespace amended to be consistent with rest of file.
Applied to u-boot-nand-flash next.
drivers/mtd/nand/nand_base.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 7171bdd..ed1c9c9 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, } }
- if (!type) + if (!type) { + printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID:" + " 0x%02x, Chip ID: 0x%02x\n", __func__, + *maf_id, dev_id); return ERR_PTR(-ENODEV); + }
if (!mtd->name) mtd->name = type->name;

Hey Scott,
On Wednesday 23 June 2010 23:53:01 Scott Wood wrote:
From: Florian Fainelli florian@openwrt.org
When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.
Signed-off-by: Florian Fainelli f.fainelli@gmail.com Signed-off-by: Scott Wood scottwood@freescale.com
Whitespace amended to be consistent with rest of file.
Thanks, I was just about to respin it.
Applied to u-boot-nand-flash next.
drivers/mtd/nand/nand_base.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 7171bdd..ed1c9c9 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, } }
- if (!type)
if (!type) {
printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID:"
" 0x%02x, Chip ID: 0x%02x\n", __func__,
*maf_id, dev_id);
return ERR_PTR(-ENODEV);
}
if (!mtd->name) mtd->name = type->name;
participants (2)
-
Florian Fainelli
-
Scott Wood