[PATCH] net: phy: Request rgmii-id phy reset gpio as output

From: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com
Request the reset gpio of the rgmii-id phy as output to be consistent with the eth-phy-uclass driver.
Signed-off-by: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com ---
drivers/net/phy/ethernet_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/ethernet_id.c b/drivers/net/phy/ethernet_id.c index 8864f99bb3..a715e83db9 100644 --- a/drivers/net/phy/ethernet_id.c +++ b/drivers/net/phy/ethernet_id.c @@ -39,7 +39,7 @@ struct phy_device *phy_connect_phy_id(struct mii_dev *bus, struct udevice *dev,
if (!IS_ENABLED(CONFIG_DM_ETH_PHY)) { ret = gpio_request_by_name_nodev(node, "reset-gpios", 0, &gpio, - GPIOD_ACTIVE_LOW); + GPIOD_IS_OUT | GPIOD_ACTIVE_LOW); if (!ret) { assert = ofnode_read_u32_default(node, "reset-assert-us", 0);

On 5/2/23 14:50, Stefan Herbrechtsmeier wrote:
From: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com
Request the reset gpio of the rgmii-id phy as output to be consistent with the eth-phy-uclass driver.
Signed-off-by: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com
drivers/net/phy/ethernet_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/ethernet_id.c b/drivers/net/phy/ethernet_id.c index 8864f99bb3..a715e83db9 100644 --- a/drivers/net/phy/ethernet_id.c +++ b/drivers/net/phy/ethernet_id.c @@ -39,7 +39,7 @@ struct phy_device *phy_connect_phy_id(struct mii_dev *bus, struct udevice *dev,
if (!IS_ENABLED(CONFIG_DM_ETH_PHY)) { ret = gpio_request_by_name_nodev(node, "reset-gpios", 0, &gpio,
GPIOD_ACTIVE_LOW);
if (!ret) { assert = ofnode_read_u32_default(node, "reset-assert-us", 0);GPIOD_IS_OUT | GPIOD_ACTIVE_LOW);
Reviewed-by: Michal Simek michal.simek@amd.com
M

On Tue, May 02, 2023 at 02:50:43PM +0200, Stefan Herbrechtsmeier wrote:
From: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com
Request the reset gpio of the rgmii-id phy as output to be consistent with the eth-phy-uclass driver.
Signed-off-by: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com Reviewed-by: Michal Simek michal.simek@amd.com
Applied to u-boot/master, thanks!
participants (3)
-
Michal Simek
-
Stefan Herbrechtsmeier
-
Tom Rini