[U-Boot] [PATCH] qemu-arm: Enable VirtIO distro target
With -device virtio-blk-device,drive=hd0, it could detect distro boot target.
Signed-off-by: Sumit Garg sumit.garg@linaro.org ---
Depends on https://patchwork.ozlabs.org/patch/995524/ which adds VirtIO distro boot command.
include/configs/qemu-arm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h index fedc466..437c3ae 100644 --- a/include/configs/qemu-arm.h +++ b/include/configs/qemu-arm.h @@ -25,7 +25,8 @@
#define BOOT_TARGET_DEVICES(func) \ func(SCSI, scsi, 0) \ - func(DHCP, dhcp, na) + func(DHCP, dhcp, na) \ + func(VIRTIO, virtio, 0)
#include <config_distro_bootcmd.h>
Hi Sumit,
On Mon, 12 Nov 2018 15:29:08 +0530 Sumit Garg sumit.garg@linaro.org wrote:
With -device virtio-blk-device,drive=hd0, it could detect distro boot target.
Signed-off-by: Sumit Garg sumit.garg@linaro.org
...
diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h index fedc466..437c3ae 100644 --- a/include/configs/qemu-arm.h +++ b/include/configs/qemu-arm.h @@ -25,7 +25,8 @@
#define BOOT_TARGET_DEVICES(func) \ func(SCSI, scsi, 0) \
- func(DHCP, dhcp, na)
- func(DHCP, dhcp, na) \
- func(VIRTIO, virtio, 0)
#include <config_distro_bootcmd.h>
I think typically DHCP is the very last boot option since it can take quite long to notice if there's no DHCP server on the network and fall back to the next option. So perhaps an order of
SCSI; VIRTIO; DHCP
would be better.
Other than that, looks fine to me.
- Tuomas
Hi Tuomas,
On Tue, 13 Nov 2018 at 00:23, Tuomas Tynkkynen tuomas.tynkkynen@iki.fi wrote:
Hi Sumit,
On Mon, 12 Nov 2018 15:29:08 +0530 Sumit Garg sumit.garg@linaro.org wrote:
With -device virtio-blk-device,drive=hd0, it could detect distro boot target.
Signed-off-by: Sumit Garg sumit.garg@linaro.org
...
diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h index fedc466..437c3ae 100644 --- a/include/configs/qemu-arm.h +++ b/include/configs/qemu-arm.h @@ -25,7 +25,8 @@
#define BOOT_TARGET_DEVICES(func) \ func(SCSI, scsi, 0) \
func(DHCP, dhcp, na)
func(DHCP, dhcp, na) \func(VIRTIO, virtio, 0)#include <config_distro_bootcmd.h>
I think typically DHCP is the very last boot option since it can take quite long to notice if there's no DHCP server on the network and fall back to the next option. So perhaps an order of
SCSI; VIRTIO; DHCP
Yeah it does makes sense. Will change in v2.
-Sumit
would be better.
Other than that, looks fine to me.
- Tuomas
participants (2)
-
Sumit Garg -
Tuomas Tynkkynen